Skip to content

Bug 1867461: Adding in cookie refresh and removing prompt for provider button #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Bug 1867461: Adding in cookie refresh and removing prompt for provider button #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/k8shandler/kibana/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,9 @@ func newKibanaPodSpec(cluster *KibanaRequest, elasticsearchName string, proxyCon
fmt.Sprintf("-client-id=system:serviceaccount:%s:kibana", cluster.cluster.Namespace),
"-client-secret-file=/var/run/secrets/kubernetes.io/serviceaccount/token",
"-cookie-secret-file=/secret/session-secret",
"-cookie-refresh=10s",
Copy link
Contributor

@jcantrill jcantrill Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a matching test for this or is that a different proxy conf for maybe the es-proxy?

otherwise /lgtm

Copy link
Contributor Author

@ewolinetz ewolinetz Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcantrill i think that is a different proxy conf

"-cookie-expire=24h",
"-skip-provider-button",
"-upstream=http://localhost:5601",
"-scope=user:info user:check-access user:list-projects",
"--tls-cert=/secret/server-cert",
Expand Down