-
Notifications
You must be signed in to change notification settings - Fork 90
Bug 1883444: capping primary shard count at 5 for performance reasons #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1883444: capping primary shard count at 5 for performance reasons #505
Conversation
jcantrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
86cff43 to
9bf1b6c
Compare
|
@ewolinetz: This pull request references Bugzilla bug 1883444, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
periklis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one optional suggestion to limit map[string]interface{} usage.
|
/hold |
|
/retest |
…e the primary shard for index templates to ensure it accurately is reflected for new indices that are created
3b14259 to
9068ee7
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blockloop, ewolinetz, jcantrill, periklis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/uncc @alanconway |
|
/retest |
|
@ewolinetz: This pull request references Bugzilla bug 1883444, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ewolinetz: All pull requests linked via external trackers have merged: Bugzilla bug 1883444 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@ewolinetz: #505 failed to apply on top of branch "release-4.5": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@ewolinetz: new pull request created: #515 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also updating reconcile loop to update the primary shard for index templates to ensure it accurately is reflected for new indices that are created.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1883444