Skip to content

Bug 1883444: Updating index template logic to cap primary shards #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

Bug 1883444: Updating index template logic to cap primary shards #574

merged 1 commit into from
Nov 17, 2020

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Nov 13, 2020 •
edited
Loading

Description

Updating index template logic to correctly use function to calculate primary shards instead of just counting data nodes

/cc @blockloop
/assign @jcantrill

Links

@ewolinetz
Updating index template logic to correctly use function to calculate …
71c068f 
…primary shards instead of just counting data nodes
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2020

@ewolinetz: This pull request references Bugzilla bug 1883444, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1883444: Updating index template logic to cap primary shards

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2020

@ewolinetz: This pull request references Bugzilla bug 1883444, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1883444: Updating index template logic to cap primary shards

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Nov 13, 2020

this will need a manual cherrypick to 4.6 to reuse existing BZs

@ewolinetz ewolinetz mentioned this pull request Nov 13, 2020
Merged
blockloop
blockloop approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@jcantrill
Copy link
Contributor

jcantrill commented Nov 14, 2020

/lgtm

@jcantrill
Copy link
Contributor

jcantrill commented Nov 14, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, ewolinetz, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f32b02d into openshift:master Nov 17, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2020

@ewolinetz: All pull requests linked via external trackers have merged:

Bugzilla bug 1883444 has been moved to the MODIFIED state.

In response to this:

Bug 1883444: Updating index template logic to cap primary shards

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blockloop blockloop blockloop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blockloop blockloop

@jcantrill jcantrill

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ewolinetz @openshift-ci-robot @jcantrill @openshift-bot @blockloop @openshift-merge-robot