Skip to content

Conversation

@lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented Oct 23, 2020

Description

Updating Elasticsearch metrics dashboard. Improving some charts and updating the dashboard title.

/cc @blockloop
/assign @ewolinetz

image

@lukas-vlcek
Copy link
Contributor Author

@mburke5678 Mike, this PR will bring the Elasticsearch dashboard in sync with the latest documentation.

@ewolinetz
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
Copy link
Contributor

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a screenshot of the new dashboard and explain the changes in the description, please?

@mburke5678
Copy link

@lukas-vlcek @ewolinetz How are these changes planned to be introduced? Using a z-stream?

@ewolinetz
Copy link
Contributor

@mburke5678 currently with this PR it will go in with out as 4.7 since its going into master

@lukas-vlcek
Copy link
Contributor Author

lukas-vlcek commented Oct 29, 2020

@blockloop The screenshot is the same one that is attached to https://issues.redhat.com/browse/LOG-700
It did not change. For some reason we got into the repo some older version of the dashboard. This PR brings in the same version of dashboard that is in LOG-700.

As for the naming I would refer to communication I had with @sichvoge (it is buried deep in Slack).

@ewolinetz In fact this should really go to 4.6 if possible asap.

@lukas-vlcek lukas-vlcek changed the title Update Elasticsearch dashboard Bug 1892755: Update Elasticsearch dashboard Oct 29, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 29, 2020
@openshift-ci-robot
Copy link

@lukas-vlcek: This pull request references Bugzilla bug 1892755, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1892755: Update Elasticsearch dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 29, 2020
@lukas-vlcek
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 29, 2020
@openshift-ci-robot
Copy link

@lukas-vlcek: This pull request references Bugzilla bug 1892755, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lukas-vlcek
Copy link
Contributor Author

/cherrypick release-4.6

@openshift-cherrypick-robot

@lukas-vlcek: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@lukas-vlcek: This pull request references Bugzilla bug 1892755, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1892755: Update Elasticsearch dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@blockloop
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, ewolinetz, lukas-vlcek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5dd0f4f into openshift:master Oct 29, 2020
@openshift-ci-robot
Copy link

@lukas-vlcek: All pull requests linked via external trackers have merged:

Bugzilla bug 1892755 has been moved to the MODIFIED state.

In response to this:

Bug 1892755: Update Elasticsearch dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@lukas-vlcek: new pull request created: #558

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants