-
Notifications
You must be signed in to change notification settings - Fork 90
Update sdk to 0.1.0 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josefkarasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@josefkarasek: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
what is the file /main? This is a large binary file? |
|
|
||
| // SchemeBuilder is used to add go types to the GroupVersionKind scheme | ||
| // SchemeBuilder = &scheme.Builder{GroupVersion: SchemeGroupVersion} | ||
| SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josefkarasek Any reason why you're using the apimachinery runtime.NewSchemeBuilder vs the controller-runtime's wrapper &scheme.Builder{GroupVersion: SchemeGroupVersion}?
I'm curious because your types.go and register.go files are quite different from the default that the sdk scaffolds.
As an example if you look at the following:
https://github.com/operator-framework/operator-sdk-samples/blob/master/memcached-operator/pkg/apis/cache/v1alpha1/memcached_types.go#L41-L43
https://github.com/operator-framework/operator-sdk-samples/blob/master/memcached-operator/pkg/apis/cache/v1alpha1/register.go#L18
For registering custom types not defined under your pkg/apis/... I would suggest to register those types with the manager's scheme in your cmd/manager/main.go.
https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md#register-with-the-managers-scheme
import (
monitoring "github.com/coreos/prometheus-operator/pkg/apis/monitoring/v1"
)
func main() {
....
if err := monitoring.AddToScheme(mgr.GetScheme()); err != nil {
...
}
....
}That should register all types with the manager's scheme.
|
/retest |
|
@josefkarasek: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
this PR is obsoleted by #118 |
No description provided.