Skip to content

Conversation

@josefkarasek
Copy link

No description provided.

@josefkarasek
Copy link
Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josefkarasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@openshift-ci-robot
Copy link

@josefkarasek: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2019
@richm
Copy link
Contributor

richm commented Jan 15, 2019

what is the file /main? This is a large binary file?


// SchemeBuilder is used to add go types to the GroupVersionKind scheme
// SchemeBuilder = &scheme.Builder{GroupVersion: SchemeGroupVersion}
SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josefkarasek Any reason why you're using the apimachinery runtime.NewSchemeBuilder vs the controller-runtime's wrapper &scheme.Builder{GroupVersion: SchemeGroupVersion}?

I'm curious because your types.go and register.go files are quite different from the default that the sdk scaffolds.

As an example if you look at the following:
https://github.com/operator-framework/operator-sdk-samples/blob/master/memcached-operator/pkg/apis/cache/v1alpha1/memcached_types.go#L41-L43
https://github.com/operator-framework/operator-sdk-samples/blob/master/memcached-operator/pkg/apis/cache/v1alpha1/register.go#L18

For registering custom types not defined under your pkg/apis/... I would suggest to register those types with the manager's scheme in your cmd/manager/main.go.
https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md#register-with-the-managers-scheme

import (
	monitoring "github.com/coreos/prometheus-operator/pkg/apis/monitoring/v1"
)

func main() {
    ....
    if err := monitoring.AddToScheme(mgr.GetScheme()); err != nil {
      ...
    }
    ....
}

That should register all types with the manager's scheme.

@richm
Copy link
Contributor

richm commented Feb 21, 2019

/retest

@openshift-ci-robot
Copy link

@josefkarasek: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 027bc16 link /test e2e-aws
ci/prow/images 027bc16 link /test images
ci/prow/rhel-images 027bc16 link /test rhel-images
ci/prow/e2e-operator 027bc16 link /test e2e-operator
ci/prow/unit 027bc16 link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richm
Copy link
Contributor

richm commented Apr 9, 2019

this PR is obsoleted by #118

@richm richm closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants