-
Notifications
You must be signed in to change notification settings - Fork 90
[WIP] SDK bump from v0.0.7 => v0.7.0 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Currently the code passes unit tests but looks like spaghetti. I'm going to try to restructure our code so we don't have to pass a client around all over. |
The type should either be wrappered similar to what we did for CLO or the client should be set on the struct or the thing that is already passed around everywhere |
|
does this PR obsolete #57 ? |
|
@richm yes |
d64efe8 to
9a7c4e9
Compare
|
Currently seeing |
Maybe it isn't |
|
@richm the issue ended up being that we needed to add the prometheus monitoring scheme to ours for the sdk. Once i added that in |
|
/test e2e-operator |
|
@ewolinetz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I just realized that I copied over code from a bad starting point.. i'm going to close this PR for now and reopen it when I fix it so that we aren't constantly getting CI errors emailed out |
Being done following : https://github.com/operator-framework/operator-sdk/blob/master/doc/migration/v0.1.0-migration-guide.md