Skip to content

Conversation

@ewolinetz
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2019
@ewolinetz
Copy link
Contributor Author

Currently the code passes unit tests but looks like spaghetti. I'm going to try to restructure our code so we don't have to pass a client around all over.
(Also need to fix up e2e test -- we register with the framework differently)

@jcantrill
Copy link
Contributor

Currently the code passes unit tests but looks like spaghetti. I'm going to try to restructure our code so we don't have to pass a client around all over.
(Also need to fix up e2e test -- we register with the framework differently)

The type should either be wrappered similar to what we did for CLO or the client should be set on the struct or the thing that is already passed around everywhere

@richm
Copy link
Contributor

richm commented Apr 9, 2019

does this PR obsolete #57 ?

@ewolinetz
Copy link
Contributor Author

@richm yes

@richm richm mentioned this pull request Apr 9, 2019
@ewolinetz ewolinetz force-pushed the sdk_bump branch 5 times, most recently from d64efe8 to 9a7c4e9 Compare April 10, 2019 14:46
@ewolinetz
Copy link
Contributor Author

Currently seeing no kind is registered for the type v1.ServiceMonitor in scheme \"k8s.io/client-go/kubernetes/scheme/register.go:61\" in the operator logs. asking sdk group about this since it looks like it should be added to the scheme (unless its a sdk version issue)

@richm
Copy link
Contributor

richm commented Apr 10, 2019

Currently seeing no kind is registered for the type v1.ServiceMonitor in scheme \"k8s.io/client-go/kubernetes/scheme/register.go:61\" in the operator logs. asking sdk group about this since it looks like it should be added to the scheme (unless its a sdk version issue)

Maybe it isn't v1? I know there are some other types that aren't yet v1 e.g. subscriptions.operators.coreos.com/v1alpha1

@ewolinetz
Copy link
Contributor Author

@richm the issue ended up being that we needed to add the prometheus monitoring scheme to ours for the sdk. Once i added that in cmd/manager/main.go it rectified it

@ewolinetz
Copy link
Contributor Author

/test e2e-operator

@openshift-ci-robot
Copy link

@ewolinetz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit 4beb1d7 link /test unit
ci/prow/e2e-operator 4beb1d7 link /test e2e-operator
ci/prow/images 4beb1d7 link /test images
ci/prow/e2e-aws 4beb1d7 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ewolinetz
Copy link
Contributor Author

I just realized that I copied over code from a bad starting point.. i'm going to close this PR for now and reopen it when I fix it so that we aren't constantly getting CI errors emailed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants