Skip to content

Conversation

@huikang
Copy link
Contributor

@huikang huikang commented Nov 24, 2020

Description

Handle invalid json input in the delete index script

/cc @ewolinetz
/assign @jcantrill

/cherry-pick

Links

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@periklis
Copy link
Contributor

/retitle Bug 1899905: Handle invalid json in delete script

@openshift-ci-robot openshift-ci-robot changed the title Handle invalid json in delete script Bug 1899905: Handle invalid json in delete script Nov 25, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 25, 2020
@openshift-ci-robot
Copy link

@huikang: This pull request references Bugzilla bug 1899905, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1899905: Handle invalid json in delete script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huikang, jcantrill, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@periklis
Copy link
Contributor

/cherry-pick release-4.6

@openshift-cherrypick-robot

@periklis: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huikang
Copy link
Contributor Author

huikang commented Nov 25, 2020

/retest

@huikang
Copy link
Contributor Author

huikang commented Nov 25, 2020

/test cluster-logging-operator-e2e

@openshift-merge-robot openshift-merge-robot merged commit ba5b1eb into openshift:master Nov 26, 2020
@openshift-ci-robot
Copy link

@huikang: All pull requests linked via external trackers have merged:

Bugzilla bug 1899905 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1899905: Handle invalid json in delete script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@periklis: new pull request created: #588

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huikang huikang deleted the handle-invalid-json-input branch November 26, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants