Bug 1907758: Fix update replica count for logging indices only #602

periklis · 2020-12-17T16:21:37Z

Description

This PR addresses a false negative error log in ES nodes logs. The culprit is the elasticsearch-operator trying to update .security/_settings/index.number_of_replicas setting. Such calls are currently only allowed using the admin cert/key PR directly to elasticsearch (e.g. like in es_seed_acl). This fix is not a downgrade in operating multiple replicas of the .security index. The ES init procedure for the .security index takes care to set the replicas to 1 if the ES cluster has more than one node.

Needs backports for: release-4.6

/cc @huikang
/assign @jcantrill

Links

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1907758

openshift-ci-robot · 2020-12-17T16:21:44Z

@periklis: This pull request references Bugzilla bug 1907758, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907758: Fix update replica count for logging indices only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-17T16:24:36Z

@periklis: This pull request references Bugzilla bug 1907758, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907758: Fix update replica count for logging indices only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcantrill · 2020-12-17T17:09:23Z

/approve

jcantrill · 2020-12-17T17:10:11Z

@periklis i would refrain backporting to 4.5. This is a low priority issue for which we know the problem

periklis · 2020-12-18T07:00:13Z

/retest

periklis · 2020-12-18T07:02:29Z

@periklis i would refrain backporting to 4.5. This is a low priority issue for which we know the problem

@jcantrill Good point, I set this to low priority because the present impact is only false negative error log messages in the elasticsearch log. Since users get easily distracted by this and report BZs, I would like to prevent them doing this and relief us from pointing to this BZ all the time. WDYT?

periklis · 2020-12-18T10:22:25Z

/retest

huikang · 2020-12-18T15:13:49Z

/lgtm

openshift-ci-robot · 2020-12-18T15:14:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huikang, jcantrill, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot · 2020-12-18T16:17:16Z

@periklis: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/cluster-logging-operator-e2e	`d012194`	link	`/test cluster-logging-operator-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-12-18T17:17:53Z

/retest