[release-4.6] Bug 1909616: Fix update replica count for logging indices only

[openshift-cherrypick-robot]

This is an automated cherry-pick of #602

/assign periklis

[openshift-ci-robot]

@openshift-cherrypick-robot: Bugzilla bug 1907758 has been cloned as Bugzilla bug 1909616. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1909616: Fix update replica count for logging indices only

In response to this:

[release-4.6] Bug 1907758: Fix update replica count for logging indices only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1909616, which is invalid:

• expected dependent Bugzilla bug 1907758 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1909616: Fix update replica count for logging indices only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[periklis]

/lgtm

[periklis]

/retest

[periklis]

/lgtm

[periklis]

/assign @alanconway

[jcantrill]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, openshift-cherrypick-robot, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

[openshift-ci-robot]

@openshift-bot: This pull request references Bugzilla bug 1909616, which is invalid:

• expected dependent Bugzilla bug 1907758 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[periklis]

/bugzilla refresh

[openshift-ci-robot]

@periklis: This pull request references Bugzilla bug 1909616, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1907758 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1907758 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[periklis]

@markmc I know this one has medium severity, but it produces false negative errors that trouble users when debugging their elasticsearch in production deployments. Since 4.6 is EUS I would like to see this landing to omit having to explain that this error is a false negative in slack/BZ/wherever. Please give your blessings.

[markmc]

@markmc I know this one has medium severity, but it produces false negative errors that trouble users when debugging their elasticsearch in production deployments. Since 4.6 is EUS I would like to see this landing to omit having to explain that this error is a false negative in slack/BZ/wherever. Please give your blessings.

(patch manager) I think that's a reasonable justification to increase the severity to high. Please do that and I'll prioritize it for this 4.6.z

[periklis]

/bugzilla refresh

[openshift-ci-robot]

@periklis: This pull request references Bugzilla bug 1909616, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1907758 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1907758 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[markmc]

(patch manager)

Disappointing again that all of the useful info from description in PR #602 is not reflected in this PR or commit

Issue seems to be causing confusion for real-world users, so worth the risk to 4.6 by backporting

[periklis]

(patch manager)

Disappointing again that all of the useful info from description in PR #602 is not reflected in this PR or commit

Issue seems to be causing confusion for real-world users, so worth the risk to 4.6 by backporting

@markmc Will point our team to re-eval our practice to clone the descriptions in cherry-pick PR.

[markmc]

On Tue, Dec 22, 2020 at 4:45 PM Periklis Tsirakidis < ***@***.***> wrote: (patch manager) Disappointing again that all of the useful info from description in PR #602 <#602> is not reflected in this PR or commit Issue seems to be causing confusion for real-world users, so worth the risk to 4.6 by backporting @markmc <https://github.com/markmc> Will point our team to re-eval our practice to clone the descriptions in cherry-pick PR.

Consider putting useful info like this in the commit message - that way it shows up in `git log` output without having to trace the commit back to a PR. Thanks! Mark.

[openshift-ci-robot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/elasticsearch-operator#606

Bugzilla bug 1909616 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1909616: Fix update replica count for logging indices only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.