Skip to content

Conversation

@periklis
Copy link
Contributor

Description

This PR provides a small fix in the ClusterServiceVersion deployment manifest for the elasticsearch-operator. The fix provides the correct container ports to expose http and cr metrics as expected by OLM-managed deployments.

/cc @blockloop
/assign @ewolinetz

Links

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 24, 2021
@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1924657, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "4.7.0" instead
  • expected Bugzilla bug 1924657 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1924657: Fix metrics ports exposed by operator deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 24, 2021
@periklis
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1924657, which is invalid:

  • expected Bugzilla bug 1924657 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huikang
Copy link
Contributor

huikang commented Feb 24, 2021

@periklis , should this port be 8080 for the operator container since we upgrade to sdk 1.2?

@periklis
Copy link
Contributor Author

@periklis , should this port be 8080 for the operator container since we upgrade to sdk 1.2?

You are right for upcoming release branching of master, i.e. 5.0.0. However, in release-4.6 we are still using the old operator-sdk.

periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Feb 24, 2021
@ewolinetz
Copy link
Contributor

@periklis we already have the fix for this covered in 5.0 correct?

@ewolinetz
Copy link
Contributor

/approve

@ewolinetz ewolinetz added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 24, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@ewolinetz
Copy link
Contributor

adding valid bug label because we are not producing a 4.7 release in Cluster Logging (we are disconnected from needing to provide this in bugzilla already)

periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Feb 25, 2021
@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit 020d858 into openshift:release-4.6 Feb 26, 2021
@openshift-ci-robot
Copy link

@periklis: All pull requests linked via external trackers have merged:

Bugzilla bug 1924657 has been moved to the MODIFIED state.

In response to this:

Bug 1924657: Fix metrics ports exposed by operator deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 1, 2021
periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 1, 2021
periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 1, 2021
periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 1, 2021
periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 3, 2021
periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 3, 2021
periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 3, 2021
periklis added a commit to periklis/elasticsearch-operator that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants