Fix operator ports for metrics endpoint #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
periklis
force-pushed
the
fwp-bz-1924657
branch
from
ed1055d to
34dac0b
Compare
|
/retest |
periklis
force-pushed
the
fwp-bz-1924657
branch
5 times, most recently
from
cf5d848 to
4b59686
Compare
periklis
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
huikang
reviewed
Mar 3, 2021
...anifests/elasticsearch-operator-metrics-monitor_monitoring.coreos.com_v1_servicemonitor.yaml
Show resolved
Hide resolved
|
/retest |
This PR is a cherry-pick of openshift#652 to ensure porting fix forward for https://bugzilla.redhat.com/show_bug.cgi?id=1924657.
|
/test e2e-upgrade |
|
nit, this doesn't seem like a cherrypick of the prior pr. can you give a tl;dr in the pr description as to what was wrong since there are 29 files here? /approve |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, huikang, periklis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a cherry-pick of #652 to ensure porting fix forward for https://bugzilla.redhat.com/show_bug.cgi?id=1924657.
This is not an automatic cherry-pick because the approach to adapt the CSV and required k8s resources to expose metrics port and service monitors is different to what we used in pre operator-sdk 1.x times. Since 5.0 we use operator-sdk 1.2 and in turn the new kustomize-based machinery to apply changes into the operators CSV.
/cc @huikang
/assign @ewolinetz
Links