Skip to content

Conversation

@periklis
Copy link
Contributor

Description

This PR is a mandatory follow up for #665 and #653. I.e. it includes the missing bits for running E2E tests safely on our CI:

  • Use only registry.ci.openshift.org hosted images. In contrast the EO deployment used gcr.io to pull the image for kube-rbac-proxy. Later is the additional sidecar introduced by Fix operator ports for metrics endpoint #653 to protect the operator metrics.
  • Match deployment image after patching the subscription by using containers[1].image instead of containers[0].image. On index zero we have the kube-rbac-proxy container and on index one the elasticsearch-operator container.

/cc @huikang
/assign @ewolinetz

Copy link
Contributor

@huikang huikang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing this!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@ewolinetz
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, huikang, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 034c5fe into openshift:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants