Allow building on unsupported architectures

[yselkowitz]

Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

[openshift-ci-robot]

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yselkowitz
To complete the pull request process, please assign hexfusion
You can assign the PR to them by writing /assign @hexfusion in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

@yselkowitz what arch are you trying to support? Not sure how I feel about carrying a patch for this, all etcd code is upstream minus CI tooling.

[yselkowitz]

@hexfusion, sorry, I didn't see a Dockerfile.rhel upstream. In which branch is it?

[hexfusion]

@hexfusion, sorry, I didn't see a Dockerfile.rhel upstream. In which branch is it?

Well, it was my misunderstanding actually. Have you tested this? I get

2019-07-11 12:24:00.054992 W | pkg/flags: unrecognized environment variable ETCD_UNSUPPORTED_ARCH=`uname -m`

Also this would set this ENV for every build this and might confuse folks. Why can't you pass the ENV during runtime?

[hexfusion]

/ok-to-test

just so we can review output

[hexfusion]

/hold

[hexfusion]

status update, etcd team is looking into this.

[yselkowitz]

Could we get an update on this please? This is a prerequisite of OpenShift on IBM Z.

[hexfusion]

We will have a PR by Friday for review

On Wed, Aug 28, 2019 at 11:24 AM Yaakov Selkowitz ***@***.***> wrote: Could we get an update on this please? This is a prerequisite of OpenShift on IBM Z. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15?email_source=notifications&email_token=AAJRDVPV2SG4NJJC6ITJ6BDQG2KBRA5CNFSM4IAQVKMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LQAVA#issuecomment-525795412>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJRDVPIHEURZOZKDAY3R4TQG2KBRANCNFSM4IAQVKMA> .

-- —

[hexfusion]

Closed in favor of openshift/machine-config-operator#1092

[yselkowitz]

@hexfusion unfortunately that is insufficient. Not only is this a runtime issue, but actually affects the build of the container image as well.

The container does RUN make build, which not only compiles etcd but also runs it as a test. Therefore, as it currently stands, the image build itself still fails.

In order to fix the image build, either we can add ENV ETCD_UNSUPPORTED_ARCH=$(go env GOARCH) where the first part of my patch would have set =1, or the Makefile needs to be modified to set that in the make environment, or the upstream code needs to be relaxed as originally proposed.

Please reopen so that a new patch can be proposed accordingly.

[hexfusion]

In order to fix the image build, either we can add ENV ETCD_UNSUPPORTED_ARCH=$(go env GOARCH) where the first part of my patch would have set =1, or the Makefile needs to be modified to set that in the make environment, or the upstream code needs to be relaxed as originally proposed.

That makes sense but we do not want to carry a patch to do this. The build process itself has no care about arch but the make tooling showed a limitation. I have adjusted the build process[1] as an alternative allowing build on any arch. The MCO[2] change will allow your binaries to run.

[1] #17
[2] openshift/machine-config-operator#1092