NE-2780: Add `v1.2.3` bundle to all FBC catalogs by alebedev87 · Pull Request #508 · openshift/external-dns-operator

alebedev87 · 2026-06-23T14:19:11Z

Summary

Add external-dns-operator.v1.2.3 bundle to all FBC catalog-template.yaml files (v4.12–v4.22) in stable-v1 and stable-v1.2 channels using registry.redhat.io. Regenerate catalog.yaml files using make generate-catalog.

coderabbitai · 2026-06-23T14:19:44Z

📝 Walkthrough

Walkthrough

This PR updates OLM catalog templates and generated catalog YAMLs for v4.12 through v4.22 to add external-dns-operator.v1.2.3. In both stable-v1 and stable-v1.2, the upgrade graph now includes v1.2.3 after v1.2.2, and v1.3.0 is retargeted to replace v1.2.3. Each affected catalog also adds or replaces the corresponding olm.bundle metadata for external-dns-operator.v1.2.3, including the bundle image digest, package properties, embedded bundle object data, and related images.

Possibly related PRs

openshift/external-dns-operator#482: Updates the same OLM upgrade graph pattern for a prior external-dns-operator release.

Suggested reviewers

davidesalerno
jcmoraisjr

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes catalog YAMLs; no Ginkgo test definitions or titles were modified, so the naming rule is not applicable.
Test Structure And Quality	✅ Passed	PR only updates catalog YAMLs; no Ginkgo test code was changed, so the test-quality checklist isn’t applicable.
Microshift Test Compatibility	✅ Passed	The PR only changes catalog YAML files; no Ginkgo e2e tests or other test code were added or modified, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR changes only catalog YAMLs; no new Ginkgo e2e tests were added, so there are no SNO assumptions to flag.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR only updates FBC catalog YAMLs; affected files contain no nodeSelector/affinity/PDB/topologySpread constraints, and the new v1.2.3 bundle block is CSV/image metadata only.
Ote Binary Stdout Contract	✅ Passed	PR only changes catalog YAML files; no process-level code paths (main/init/TestMain/suite setup) or stdout writes were touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes catalog YAML templates/manifests; no new Ginkgo e2e tests or IP/host networking code were added, so this check is not applicable.
No-Weak-Crypto	✅ Passed	No weak-crypto primitives or custom crypto were added; the touched catalog YAMLs only add registry sha256 image digests and OLM metadata.
Container-Privileges	✅ Passed	PASS: The PR only updates catalog metadata; the touched YAMLs contain no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	Changed files are catalog YAML only; scans found no log statements or real secrets/PII, just public registry refs and sample `alm-examples` data.
Description check	✅ Passed	The description is clearly related to the change set and mentions the catalog updates and regeneration.
Title check	✅ Passed	The title clearly matches the main change: adding the v1.2.3 bundle across the FBC catalogs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

Add `v1.2.3` bundle to all FBC `catalog-template.yaml` files (v4.12–v4.22) in `stable-v1` and `stable-v1.2` channels using `registry.redhat.io`. Regenerate `catalog.yaml` files using `make generate-catalog`. Co-Authored-By: Claude

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@catalog/v4.22/catalog-template.yaml`:
- Around line 144-146: The new bundle record is not aligned with the surrounding
entries list, so update the catalog template entry under entries by indenting
the external-dns-operator.v1.2.3 bundle fields consistently with the other list
items. Use the existing YAML structure in catalog-template.yaml as the reference
and ensure the image, name, and schema fields stay grouped beneath the same
entries item so the list remains valid.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7780d7d7-d82c-4215-9e25-287f839611e8

📥 Commits

Reviewing files that changed from the base of the PR and between a61f2c9 and 9d0dec6.

📒 Files selected for processing (22)

catalog/v4.12/catalog-template.yaml
catalog/v4.12/catalog.yaml
catalog/v4.13/catalog-template.yaml
catalog/v4.13/catalog.yaml
catalog/v4.14/catalog-template.yaml
catalog/v4.14/catalog.yaml
catalog/v4.15/catalog-template.yaml
catalog/v4.15/catalog.yaml
catalog/v4.16/catalog-template.yaml
catalog/v4.16/catalog.yaml
catalog/v4.17/catalog-template.yaml
catalog/v4.17/catalog.yaml
catalog/v4.18/catalog-template.yaml
catalog/v4.18/catalog.yaml
catalog/v4.19/catalog-template.yaml
catalog/v4.19/catalog.yaml
catalog/v4.20/catalog-template.yaml
catalog/v4.20/catalog.yaml
catalog/v4.21/catalog-template.yaml
catalog/v4.21/catalog.yaml
catalog/v4.22/catalog-template.yaml
catalog/v4.22/catalog.yaml

🚧 Files skipped from review as they are similar to previous changes (19)

catalog/v4.14/catalog-template.yaml
catalog/v4.21/catalog-template.yaml
catalog/v4.16/catalog-template.yaml
catalog/v4.17/catalog-template.yaml
catalog/v4.18/catalog-template.yaml
catalog/v4.19/catalog-template.yaml
catalog/v4.13/catalog-template.yaml
catalog/v4.15/catalog.yaml
catalog/v4.15/catalog-template.yaml
catalog/v4.14/catalog.yaml
catalog/v4.20/catalog-template.yaml
catalog/v4.16/catalog.yaml
catalog/v4.13/catalog.yaml
catalog/v4.12/catalog.yaml
catalog/v4.19/catalog.yaml
catalog/v4.18/catalog.yaml
catalog/v4.17/catalog.yaml
catalog/v4.21/catalog.yaml
catalog/v4.20/catalog.yaml

openshift-ci-robot · 2026-06-24T09:22:25Z

@alebedev87: This pull request references NE-2780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add external-dns-operator.v1.2.3 bundle to all FBC catalog-template.yaml files (v4.12–v4.22) in stable-v1 and stable-v1.2 channels using registry.redhat.io. Regenerate catalog.yaml files using make generate-catalog.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2026-06-24T11:39:22Z

must-gather hiccup, e2e passed.

/override ci/prow/e2e-azure-operator

alebedev87 · 2026-06-24T11:39:37Z

/assign @davidesalerno

openshift-ci · 2026-06-24T11:39:44Z

@alebedev87: Overrode contexts on behalf of alebedev87: ci/prow/e2e-azure-operator

Details

In response to this:

must-gather hiccup, e2e passed.

/override ci/prow/e2e-azure-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-06-24T11:39:46Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

davidesalerno · 2026-06-24T12:16:19Z

/approve

openshift-ci · 2026-06-24T12:20:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidesalerno

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [davidesalerno]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

davidesalerno · 2026-06-24T15:02:23Z

/lgtm

openshift-ci Bot requested review from jcmoraisjr and rikatz June 23, 2026 14:24

Add v1.2.3 bundle to all FBC catalogs

9d0dec6

Add `v1.2.3` bundle to all FBC `catalog-template.yaml` files (v4.12–v4.22) in `stable-v1` and `stable-v1.2` channels using `registry.redhat.io`. Regenerate `catalog.yaml` files using `make generate-catalog`. Co-Authored-By: Claude

alebedev87 force-pushed the test-1-2-3 branch from a61f2c9 to 9d0dec6 Compare June 24, 2026 09:13

alebedev87 changed the title ~~Add external-dns-operator.v1.2.3 stage bundle to all FBC catalogs~~ Add v1.2.3 bundle to all FBC catalogs Jun 24, 2026

coderabbitai Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread catalog/v4.22/catalog-template.yaml

alebedev87 changed the title ~~Add v1.2.3 bundle to all FBC catalogs~~ NE-2780: Add v1.2.3 bundle to all FBC catalogs Jun 24, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2026

openshift-ci Bot assigned davidesalerno Jun 24, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026

openshift-merge-bot Bot merged commit f395187 into openshift:main Jun 24, 2026
35 checks passed

This was referenced Jun 29, 2026

OCPBUGS-92839: Add external-dns-operator.v1.3.7 prod bundle to all FBC catalogs #515

Merged

NE-2799: Add external-dns-operator.v1.2.4 prod bundle to all FBC catalogs #520

Merged

Uh oh!

Conversation

alebedev87 commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 24, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

alebedev87 commented Jun 24, 2026

Uh oh!

alebedev87 commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

davidesalerno commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

davidesalerno commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alebedev87 commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

openshift-ci-robot commented Jun 24, 2026 •

edited by openshift-ci Bot

Loading