Skip to content

OCPBUGS-86568: Generate fallback BGP router-id on IPv6-only nodes#133

Open
cgoncalves wants to merge 1 commit into
openshift:release-4.22from
cgoncalves:OCPBUGS-86568
Open

OCPBUGS-86568: Generate fallback BGP router-id on IPv6-only nodes#133
cgoncalves wants to merge 1 commit into
openshift:release-4.22from
cgoncalves:OCPBUGS-86568

Conversation

@cgoncalves

@cgoncalves cgoncalves commented May 28, 2026

Copy link
Copy Markdown
Contributor

@cgoncalves
Generate fallback BGP router-id on IPv6-only nodes
f18d141 
On IPv6 single-stack clusters where nodes have no IPv4 addresses, FRR
defaults the BGP router-id to 0.0.0.0. This violates RFC 6286 and
RFC 4271, causing remote peers to reject the session with "Bad BGP
Identifier".

Derive a deterministic router-id from the node hostname using CRC32
when no explicit router-id is configured, matching the approach already
used by MetalLB's native BGP implementation.

Signed-off-by: Carlos Goncalves <cgoncalves@redhat.com>
@openshift-ci openshift-ci Bot requested review from fedepaol and oribon May 28, 2026 06:03
@openshift-ci

openshift-ci Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@cgoncalves cgoncalves changed the title Generate fallback BGP router-id on IPv6-only nodes OCPBUGS-86568: Generate fallback BGP router-id on IPv6-only nodes May 28, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 28, 2026
@openshift-ci-robot

openshift-ci-robot commented May 28, 2026

Copy link
Copy Markdown

@cgoncalves: This pull request references Jira Issue OCPBUGS-86568, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherry-picked from

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cgoncalves

cgoncalves commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 28, 2026
@openshift-ci-robot

openshift-ci-robot commented May 28, 2026

Copy link
Copy Markdown

@cgoncalves: This pull request references Jira Issue OCPBUGS-86568, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-85711 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-85711 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

Requesting review from QA contact:
/cc @evgenLevin

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from evgenLevin May 28, 2026 06:05
@openshift-ci

openshift-ci Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

@cgoncalves: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol
@oribon oribon Awaiting requested review from oribon
@evgenLevin evgenLevin Awaiting requested review from evgenLevin

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cgoncalves @openshift-ci-robot