e2e: delete applications using api #568
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrichter1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=======================================
Coverage 80.37% 80.37%
=======================================
Files 456 456
Lines 10831 10831
Branches 3067 3067
=======================================
Hits 8705 8705
Misses 2000 2000
Partials 126 126 Continue to review full report in Codecov by Sentry.
|
|
/retest |
1 similar comment
|
/retest |
| import { Common } from './Common'; | ||
|
|
||
| export class Applications { | ||
| static deleteApplication(applicationName: string) { |
There was a problem hiding this comment.
I think create-application-from-sample.spec also uses the same method in test to delete the application.
I think it would be nice to have one test that deletes from UI in it() block.
There was a problem hiding this comment.
does it look better now? :)
jrichter1
force-pushed
the
delete-app-api
branch
from
a9ed99c to
eea8319
Compare
|
/lgtm |
jrichter1
force-pushed
the
delete-app-api
branch
from
eea8319 to
d554524
Compare
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@jrichter1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/lgtm |
4 participants
Fixes
https://issues.redhat.com/browse/HAC-3706
Description
make after hooks faster and not prone to clicking errors by using the API instead or UI