remotemachineset/openstackactuator.go: re enable using clientOpts#1283
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Feb 12, 2021
Merged
Conversation
Contributor
Author
|
/hold currently has temp vendor from personal fork to test openshift/installer#4638 |
openshift-ci-robot
added
the
do-not-merge/hold
abhinavdahiya
force-pushed
the
remotemachineset_openstack
branch
from
68223e0 to
4bf7b2e
Compare
openshift-ci-robot
added
the
needs-rebase
includes the changes from openshift/installer#4638
dc89529 removed passing clientOpts to generate the machinesets as it was dropped as supported option in the installer libraries. since openshift/installer#4638 has re enabled the option and reverting the change in openstackactuator to use the configure client opts for correctly authenticating with openstack apis.
abhinavdahiya
force-pushed
the
remotemachineset_openstack
branch
from
4bf7b2e to
9e031ac
Compare
openshift-ci-robot
removed
the
needs-rebase
Contributor
Author
openshift-ci-robot
removed
the
do-not-merge/hold
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, abutcher The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dc89529 removed passing clientOpts to generate the machinesets as it was
dropped as supported option in the installer libraries.
since openshift/installer#4638 has re enabled the option
and reverting the change in openstackactuator to use the configure client opts
for correctly authenticating with openstack apis.
/assign @abutcher
xref: https://issues.redhat.com/browse/HIVE-1372