HIVE-2548: backport AWS STS fixes#2332
Conversation
In openshift#2260 we changed how we're invoking the openshift-install binary. Before: Copy openshift-install into the hive container and run it via `/usr/bin/hiveutil install-manager` After: Copy hiveutil into the installer container and run installer via `/output/hiveutil.rhel$VER install-manager` What we missed was that, for STS flows, we inject an AWS credentials file containing a `credential_process` that invoked `/usr/bin/hiveutil install-manager aws-credentials` -- but `hiveutil` no longer lives there. Fix. HIVE-2400
In openshift#2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an: /output/hiveutil not found This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode). Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
There's a few conditions that make `ln` fail to create a hard link which may be reproduced in a special volume like an emptyDir. The requirements for a symlink are way lower. Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@celebdor: This pull request references HIVE-2548 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: celebdor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mce-2.6 #2332 +/- ##
===========================================
+ Coverage 58.55% 58.58% +0.03%
===========================================
Files 182 182
Lines 25829 25849 +20
===========================================
+ Hits 15124 15144 +20
Misses 9429 9429
Partials 1276 1276
|
|
@celebdor: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
This is a manual backport for the AWS STS related fixes done in #2322 and #2325