HIVE-3047: GCP MachinePool (Network) Tags#2833
HIVE-3047: GCP MachinePool (Network) Tags#2833openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
Add a `Tags` field to the GCP MachinePool spec. This feeds into the ProviderSpec field of the same name, where specified values will be included alongside the default tag (`$infraID-$poolName`) generated by installer.
openshift-ci-robot
added
the
jira/valid-reference
|
@2uasimojo: This pull request references HIVE-3047 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2833 +/- ##
=======================================
Coverage 50.40% 50.40%
=======================================
Files 279 279
Lines 34194 34195 +1
=======================================
+ Hits 17236 17237 +1
Misses 15597 15597
Partials 1361 1361
🚀 New features to boost your workflow:
|
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/security |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Add a
Tagsfield to the GCP MachinePool spec. This feeds into the ProviderSpec field of the same name, where specified values will be included alongside the default tag ($infraID-$poolName) generated by installer.