OCPBUGS-42004: Add capability to Add Microsoft Managed Identity Sidecar Containers to HCP Pod Deployments#4801
OCPBUGS-42004: Add capability to Add Microsoft Managed Identity Sidecar Containers to HCP Pod Deployments#4801bryan-cox wants to merge 1 commit into
Conversation
Adds two functions to include the managed identity sidecar containers in a deployment. The adapter-init is added as an init container and the adapter-server is added as a sidecar container in the related pod deployment it is included in. Signed-off-by: Bryan Cox <brcox@redhat.com>
openshift-ci-robot
added
jira/severity-important
|
@bryan-cox: This pull request references Jira Issue OCPBUGS-42004, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.17 |
|
@bryan-cox: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/area hypershift-operator |
openshift-ci
Bot
added
area/hypershift-operator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
bryan-cox
changed the title
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // GetAzureCredentialsFromSecret gets the Service Principal client ID, client secret, and tenant ID from the credentials | ||
| // secret. This function will be modified a bit once the Microsoft sidecar containers support Managed Identity are | ||
| // delivered (expected Oct 2024). | ||
| func GetAzureCredentialsFromSecret(ctx context.Context, c client.Client, namespace, credsName string) (*corev1.Secret, error) { |
There was a problem hiding this comment.
I could see this one split into 2. In general, any code that requires a client, we put in the main hcp controller. This could do the same with a *corev1.Secret as an argument.
|
/hold Sorry about this - the design was not finalized. I don't have access to the OCPBUGS component so I can't see how this was communicated. In any case even if we do end up with an init/sidecar, the version of the image in there needs to be able to change without releasing a new version of HyperShift, and we need to be able to rev that without causing a thundering herd, which implies that it needs to be a field on the |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/close Closing this PR since Microsoft wants to move in a different direction and not use the Managed Identity Sidecar Containers |
|
@bryan-cox: This pull request references Jira Issue OCPBUGS-42004. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bryan-cox: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
What this PR does / why we need it:
Adds two functions to include the managed identity sidecar containers in a deployment. The adapter-init is added as an init container and the adapter-server is added as a sidecar container in the related pod deployment it is included in.
Follow on work to integrate these functions and implement managed identity in HCP will be done in OCPBUGS-42434.
Which issue(s) this PR fixes:
Fixes OCPBUGS-42004
Checklist