Skip to content

OCPBUGS-73721: Enable autoscaler from/to zero on Hypershift #7466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LiangquanLi930 wants to merge 2 commits into
base: release-4.21
Choose a base branch
from
Open

OCPBUGS-73721: Enable autoscaler from/to zero on Hypershift #7466

LiangquanLi930 wants to merge 2 commits into from

Conversation

@LiangquanLi930
Copy link
Member

@LiangquanLi930 LiangquanLi930 commented Jan 13, 2026

What this PR does / why we need it:

manual cherry-pick #6975 and #7427

@LiangquanLi930
feat(nodepool): enable nodepool autoscaling min zero
70ec297 
CNTRLPLANE-1622: Enable nodepool autoscaling min zero
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-73721, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-70320 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-70320 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

manual cherry-pick #6975 and #7427

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 13, 2026
@openshift-ci openshift-ci bot requested review from devguyio and enxebre January 13, 2026 06:10
@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/platform/aws PR/issue for AWS (AWSPlatform) platform area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jan 13, 2026
@LiangquanLi930 LiangquanLi930 force-pushed the release-4.21 branch 2 times, most recently from 99f429d to 72509bb Compare January 13, 2026 07:24
@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 13, 2026

/retest

2 similar comments
@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 14, 2026

/retest

@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 14, 2026

/retest

@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 14, 2026

/test e2e-aws-upgrade-hypershift-operator

@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 14, 2026

/retest

@muraee
Copy link
Contributor

muraee commented Jan 15, 2026

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiangquanLi930, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@LiangquanLi930
fix(nodepool): enable scale-up from zero with InPlace upgrade
619f628 
OCPBUGS-70320: enable scale-up from zero with InPlace upgrade
@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 15, 2026

/retest

@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 15, 2026

/override "ci/prow/e2e-aws-upgrade-hypershift-operator"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2026

@LiangquanLi930: LiangquanLi930 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override "ci/prow/e2e-aws-upgrade-hypershift-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LiangquanLi930
Copy link
Member Author

LiangquanLi930 commented Jan 16, 2026

/test e2e-aws-4-20

@gaol
Copy link
Contributor

gaol commented Jan 19, 2026

/verified by @gaol
I did some tests using the on-going scripts, and it passed both Replace and InPlace np node upgrade type.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 19, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2026

@gaol: This PR has been marked as verified by @gaol.

Details

In response to this:

/verified by @gaol
I did some tests using the on-going scripts, and it passed both Replace and InPlace np node upgrade type.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@celebdor
Copy link
Collaborator

celebdor commented Jan 19, 2026

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@celebdor: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-aks

/test e2e-aks-4-20

/test e2e-aks-override

/test e2e-aws

/test e2e-aws-4-20

/test e2e-aws-override

/test e2e-aws-upgrade-hypershift-operator

/test e2e-kubevirt-aws-ovn-reduced

/test images

/test okd-scos-images

/test security

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-autonode

/test e2e-aws-metrics

/test e2e-aws-minimal

/test e2e-aws-techpreview

/test e2e-azure-aks-ovn-conformance

/test e2e-conformance

/test e2e-kubevirt-aws-ovn

/test e2e-kubevirt-azure-ovn

/test e2e-kubevirt-metal-conformance

/test e2e-openstack-aws

/test e2e-openstack-aws-conformance

/test e2e-openstack-aws-csi-cinder

/test e2e-openstack-aws-csi-manila

/test e2e-openstack-aws-nfv

/test okd-scos-e2e-aws-ovn

/test reqserving-e2e-aws

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-hypershift-release-4.21-e2e-aks

pull-ci-openshift-hypershift-release-4.21-e2e-aks-4-20

pull-ci-openshift-hypershift-release-4.21-e2e-aws

pull-ci-openshift-hypershift-release-4.21-e2e-aws-4-20

pull-ci-openshift-hypershift-release-4.21-e2e-aws-upgrade-hypershift-operator

pull-ci-openshift-hypershift-release-4.21-e2e-kubevirt-aws-ovn-reduced

pull-ci-openshift-hypershift-release-4.21-images

pull-ci-openshift-hypershift-release-4.21-okd-scos-images

pull-ci-openshift-hypershift-release-4.21-security

pull-ci-openshift-hypershift-release-4.21-unit

pull-ci-openshift-hypershift-release-4.21-verify
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sjenning
Copy link
Contributor

sjenning commented Jan 19, 2026

/override ci/prow/e2e-aws-upgrade-hypershift-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-upgrade-hypershift-operator

Details

In response to this:

/override ci/prow/e2e-aws-upgrade-hypershift-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@LiangquanLi930: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devguyio devguyio Awaiting requested review from devguyio

@enxebre enxebre Awaiting requested review from enxebre

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/platform/aws PR/issue for AWS (AWSPlatform) platform area/testing Indicates the PR includes changes for e2e testing jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LiangquanLi930 @openshift-ci-robot @muraee @gaol @celebdor @sjenning