Skip to content

Conversation

@LiangquanLi930
Copy link
Member

The test name 'autoscaling-scale-from-zero' generates IAM role names that exceed AWS's 64 character limit when combined with the component name 'cloud-network-config-controller' (65 chars total).

Shortened to 'scale-from-zero' to fix the issue (53 chars total).

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

… limit

The test name 'autoscaling-scale-from-zero' generates IAM role names that
exceed AWS's 64 character limit when combined with the component name
'cloud-network-config-controller' (65 chars total).

Shortened to 'scale-from-zero' to fix the issue (53 chars total).
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Walkthrough

Removed version gating assertions from two autoscaling test functions and renamed an e2e run artifact path identifier in one test function, reducing version constraints for test execution.

Changes

Cohort / File(s) Summary
E2E Test Modifications
test/e2e/autoscaling_test.go
Removed e2eutil.AtLeast(t, e2eutil.Version420) version gating from TestNodePoolAutoscalingScaleFromZero and testAutoscalingBalancing. Renamed Execute argument from "autoscaling-scale-from-zero" to "scale-from-zero" in test artifact path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from csrwng and sjenning January 21, 2026 05:39
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jan 21, 2026
@sdminonne
Copy link
Contributor

/test e2e-aks

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

@LiangquanLi930: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sjenning sjenning changed the title fix(test): shorten scale-from-zero test name to avoid IAM role length limit NO-JIRA: fix(test): shorten scale-from-zero test name to avoid IAM role length limit Jan 21, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2026
@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request explicitly references no jira issue.

Details

In response to this:

The test name 'autoscaling-scale-from-zero' generates IAM role names that exceed AWS's 64 character limit when combined with the component name 'cloud-network-config-controller' (65 chars total).

Shortened to 'scale-from-zero' to fix the issue (53 chars total).

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjenning
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiangquanLi930, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026
@devguyio
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026
@LiangquanLi930
Copy link
Member Author

/verified by e2e test

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 21, 2026
@openshift-ci-robot
Copy link

@LiangquanLi930: This PR has been marked as verified by e2e test.

Details

In response to this:

/verified by e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 529fa99 into openshift:main Jan 22, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants