-
Notifications
You must be signed in to change notification settings - Fork 433
NO-JIRA: fix(test): shorten scale-from-zero test name to avoid IAM role length limit #7558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: fix(test): shorten scale-from-zero test name to avoid IAM role length limit #7558
Conversation
… limit The test name 'autoscaling-scale-from-zero' generates IAM role names that exceed AWS's 64 character limit when combined with the component name 'cloud-network-config-controller' (65 chars total). Shortened to 'scale-from-zero' to fix the issue (53 chars total).
WalkthroughRemoved version gating assertions from two autoscaling test functions and renamed an e2e run artifact path identifier in one test function, reducing version constraints for test execution. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing touches
Comment |
|
/test e2e-aks |
|
@LiangquanLi930: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@LiangquanLi930: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiangquanLi930, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/verified by e2e test |
|
@LiangquanLi930: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The test name 'autoscaling-scale-from-zero' generates IAM role names that exceed AWS's 64 character limit when combined with the component name 'cloud-network-config-controller' (65 chars total).
Shortened to 'scale-from-zero' to fix the issue (53 chars total).
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Checklist: