CNTRLPLANE-2580: feat(claude): update /update-konflux-tasks to work without log file #7591
Conversation
Makes the enterprise contract log file optional. When not provided, the skill uses update_trusted_task_bundles.py to detect updates. This enables automated periodic checking for task bundle updates. JIRA: CNTRLPLANE-2580
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Comment |
openshift-ci
bot
added
the
area/ai
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
bryan-cox
changed the title
|
@bryan-cox: This pull request references CNTRLPLANE-2580 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.claude/commands/update-konflux-tasks.md:
- Line 122: Replace the incorrect lowercase pip package name `pyyaml` with the
correct `PyYAML` where the requirement for running
update_trusted_task_bundles.py without a log file is documented; search for the
string `pyyaml` in the .claude commands content (reference: mention of
update_trusted_task_bundles.py) and update it to `PyYAML` so pip install
instructions and requirements match the real package name.
- Line 107: Change the pip install instruction for PyYAML to the correct package
name: replace the string "pip install pyyaml" with "pip install PyYAML" in the
documentation where the dependency for update_trusted_task_bundles.py is
mentioned so readers install the accurate package; ensure the displayed command
uses exact capitalization "PyYAML".
| - If skopeo is not installed, provide installation instructions | ||
| - If jq is not installed, provide installation instructions | ||
| - If yq is not installed, provide installation instructions | ||
| - If PyYAML is not installed (required for update_trusted_task_bundles.py), provide installation instructions: `pip install pyyaml` |
There was a problem hiding this comment.
Correct the PyYAML package name for pip installation.
The pip package name should be PyYAML (with capital letters), not pyyaml.
📝 Proposed fix for package name
-- If PyYAML is not installed (required for update_trusted_task_bundles.py), provide installation instructions: `pip install pyyaml`
+- If PyYAML is not installed (required for update_trusted_task_bundles.py), provide installation instructions: `pip install PyYAML`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - If PyYAML is not installed (required for update_trusted_task_bundles.py), provide installation instructions: `pip install pyyaml` | |
| - If PyYAML is not installed (required for update_trusted_task_bundles.py), provide installation instructions: `pip install PyYAML` |
🤖 Prompt for AI Agents
In @.claude/commands/update-konflux-tasks.md at line 107, Change the pip install
instruction for PyYAML to the correct package name: replace the string "pip
install pyyaml" with "pip install PyYAML" in the documentation where the
dependency for update_trusted_task_bundles.py is mentioned so readers install
the accurate package; ensure the displayed command uses exact capitalization
"PyYAML".
| - `skopeo` must be installed (for container image inspection) | ||
| - `jq` must be installed (for JSON parsing) | ||
| - `yq` must be installed (for YAML parsing and checking multi-platform builds) | ||
| - `pyyaml` Python package must be installed when running without a log file (for update_trusted_task_bundles.py) |
There was a problem hiding this comment.
Correct the PyYAML package name in requirements.
The pip package name should be PyYAML (with capital letters), not pyyaml, to match the correct pip installation command.
📝 Proposed fix for package name
-- `pyyaml` Python package must be installed when running without a log file (for update_trusted_task_bundles.py)
+- `PyYAML` Python package must be installed when running without a log file (for update_trusted_task_bundles.py)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - `pyyaml` Python package must be installed when running without a log file (for update_trusted_task_bundles.py) | |
| - `PyYAML` Python package must be installed when running without a log file (for update_trusted_task_bundles.py) |
🤖 Prompt for AI Agents
In @.claude/commands/update-konflux-tasks.md at line 122, Replace the incorrect
lowercase pip package name `pyyaml` with the correct `PyYAML` where the
requirement for running update_trusted_task_bundles.py without a log file is
documented; search for the string `pyyaml` in the .claude commands content
(reference: mention of update_trusted_task_bundles.py) and update it to `PyYAML`
so pip install instructions and requirements match the real package name.
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@bryan-cox: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jparrill
left a comment
jparrill
left a comment
There was a problem hiding this comment.
/lgtm
The change looks good, thing is, last time I used the skill it didn't work properly. I think it's matter of work on it back and forth until it works in one-shot :)
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
update_trusted_task_bundles.py --dry-run --jsonto automatically detect outdated Tekton task bundlesTest plan
/update-konflux-tasksworks with a log file (existing behavior)/update-konflux-tasksworks without a log file (new behavior)🤖 Generated with Claude Code