NO-JIRA: test(assets): add unit test for CAPI resources file paths

[cblecker]

Summary

Add a unit test to verify all entries in the capiResources map point to existing embedded files that parse correctly. This catches mismatches between the map and actual CRD file paths at test time rather than causing runtime panics.

Problem

PR #7305 introduced an edge case CI failure where CRD file paths were renamed but the capiResources map wasn't updated to match, causing runtime panics when trying to open non-existent embedded files.

Solution

The test iterates through all entries in capiResources and calls getCustomResourceDefinition() for each path, verifying:

• The embedded file exists
• The file parses correctly as YAML

Changes

• cmd/install/assets/assets_test.go (new file): Implements TestCapiResources with:
  • Positive test case: Validates all current capiResources paths exist and parse
  • Negative test case: Verifies non-existent paths correctly panic

Testing

go test -v ./cmd/install/assets/... -run TestCapiResources

All tests pass successfully. The test will catch any future mismatches between the capiResources map and embedded CRD file paths.

[coderabbitai]

Walkthrough

Adds unit tests for the assets package in cmd/install/assets/assets_test.go. The new TestCapiResources test validates that the getCustomResourceDefinition function correctly processes existing custom resource definition paths without panic and returns non-nil values, while also verifying that non-existent paths trigger panic behavior.

Changes

Cohort / File(s)	Change Summary
Assets Package Tests cmd/install/assets/assets_test.go	Added TestCapiResources unit test that iterates over capiResources paths, asserts successful execution of getCustomResourceDefinition(CRDS, path) with non-nil results, and verifies panic behavior for non-existent paths

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@cblecker: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Add a unit test to verify all entries in the capiResources map point to existing embedded files that parse correctly. This catches mismatches between the map and actual CRD file paths at test time rather than causing runtime panics.

Problem

PR #7305 introduced an edge case CI failure where CRD file paths were renamed but the capiResources map wasn't updated to match, causing runtime panics when trying to open non-existent embedded files.

Solution

The test iterates through all entries in capiResources and calls getCustomResourceDefinition() for each path, verifying:

• The embedded file exists
• The file parses correctly as YAML

Changes

• cmd/install/assets/assets_test.go (new file): Implements TestCapiResources with:
• Positive test case: Validates all current capiResources paths exist and parse
• Negative test case: Verifies non-existent paths correctly panic

Testing

go test -v ./cmd/install/assets/... -run TestCapiResources

All tests pass successfully. The test will catch any future mismatches between the capiResources map and embedded CRD file paths.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[csrwng]

/verified by unit test
/approve

[openshift-ci-robot]

@csrwng: This PR has been marked as verified by unit test.

Details

In response to this:

/verified by unit test
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cblecker]

/retest-required

[openshift-ci]

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[apahim]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apahim, cblecker, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cblecker]

/area platform/gcp