Skip to content

AUTOSCALE-485: bump karpenter-aws dependencies to 1.8.6#7611

Draft
maxcao13 wants to merge 2 commits intoopenshift:mainfrom
maxcao13:karpenter-1.8.6
Draft

AUTOSCALE-485: bump karpenter-aws dependencies to 1.8.6#7611
maxcao13 wants to merge 2 commits intoopenshift:mainfrom
maxcao13:karpenter-1.8.6

Conversation

@maxcao13
Copy link
Member

What this PR does / why we need it:

Bumps karpenter-aws and karpenter core library deps to 1.8.6 and 1.8.2 respectively.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxcao13
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/karpenter-operator Indicates the PR includes changes related to the Karpenter operator area/platform/aws PR/issue for AWS (AWSPlatform) platform and removed do-not-merge/needs-area labels Jan 30, 2026
@openshift-ci openshift-ci bot added area/platform/azure PR/issue for Azure (AzurePlatform) platform area/platform/openstack PR/issue for OpenStack (OpenStackPlatform) platform labels Jan 30, 2026
@maxcao13
Copy link
Member Author

/test e2e-aws-autonode

@maxcao13
Copy link
Member Author

maxcao13 commented Jan 30, 2026

Seems like it's passing all businless logic e2e tests, except the obvious one where I hacked the image in and forced an always imagePullPolicy on the container.

: TestKarpenter/Main/Karpenter_operator_plumbing_and_smoketesting 	1s
: TestKarpenter/Main/Control_plane_upgrade_and_Karpenter_Drift 	25m13s
: TestKarpenter/Main/Instance_profile_annotation_propagation 	10m10s
: TestKarpenter/Main/Test_basic_provisioning_and_deprovising 	6m57s

This PR will wait until openshift/kubernetes-sigs-karpenter#16 and subsequently openshift/aws-karpenter-provider-aws#25 are merged, before I reconfigure this PR to those changes and undraft, but right now I don't see any regressions.

@maxcao13 maxcao13 changed the title WIP: bump karpenter-aws dependencies to 1.8.6 AUTOSCALE-485: bump karpenter-aws dependencies to 1.8.6 Feb 3, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 3, 2026

@maxcao13: This pull request references AUTOSCALE-485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Bumps karpenter-aws and karpenter core library deps to 1.8.6 and 1.8.2 respectively.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2026
maxcao13 and others added 2 commits February 6, 2026 18:59
Bumps karpenter downstream deps to 1.8.2 and 1.8.6.
Also syncs karpenter CRDS and adjust cel.

This commit also adds the sync-crds.sh and adjust-cel.sh scripts to the karpenter-api target.

Signed-off-by: Max Cao <macao@redhat.com>
Karpenter > 1.7 manages instance profiles, and without this permission
the logs are full of errors when it tries to perpetually list instances.
This adds the permission so it can see all of the instances.
@maxcao13
Copy link
Member Author

maxcao13 commented Feb 7, 2026

/test e2e-aws-techpreview e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2026

@maxcao13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-autonode b3ccfc6 link false /test e2e-aws-autonode
ci/prow/e2e-aws-techpreview e39ebd9 link false /test e2e-aws-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/karpenter-operator Indicates the PR includes changes related to the Karpenter operator area/platform/aws PR/issue for AWS (AWSPlatform) platform area/platform/azure PR/issue for Azure (AzurePlatform) platform area/platform/openstack PR/issue for OpenStack (OpenStackPlatform) platform do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants