[release-4.21] OCPSTRAT-2437: add unit test for custom HAProxy image annotation#7646
Conversation
Refactor TestResolveHAProxyImage to validate that custom HAProxy images are properly rendered into the final kube-apiserver-proxy.yaml manifest within the ignition configuration. The test now: - Creates a complete NodePoolReconciler with fake client and providers - Generates the full HAProxy raw config including MachineConfig - Unmarshals and inspects the nested ignition configuration - Verifies the HAProxy image appears in the static pod manifest This provides more robust validation that custom HAProxy images flow correctly through the entire configuration generation pipeline.
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OCPSTRAT-2437 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
area/hypershift-operator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/retest |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
This is an automated cherry-pick of #7458
/assign mgencur