-
Notifications
You must be signed in to change notification settings - Fork 441
CNTRLPLANE-2700: docs: add HCP networking requirements documentation #7654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdds a new comprehensive documentation file detailing Hosted Control Plane (HCP) networking requirements, including ingress/egress port configurations across multiple platforms, security considerations, and network policy guidance. Updates the documentation site navigation to reference the new file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
62ecf71 to
6449179
Compare
|
/retitle CNTRLPLANE-2700: docs: add HCP networking requirements documentation |
|
@bryan-cox: This pull request references CNTRLPLANE-2700 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
e00fc87 to
25b6bec
Compare
|
@bryan-cox: This pull request references CNTRLPLANE-2700 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bryan-cox: This pull request references CNTRLPLANE-2700 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @devguyio |
jparrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice, I think this will be very useful for multiple users and customers 👏 👏 👏 . Dropped some comments.
| | 2040 | Kubernetes API Server (IBM Cloud) | Cluster management on IBM Cloud platform | IBM Cloud only | | ||
| | 8091 | Konnectivity Server | Establish reverse tunnel for control plane access | NodePort/LoadBalancer publishing only | | ||
| | 8443 | Ignition Proxy | Retrieve bootstrap configuration | NodePort publishing only (Agent/None platforms) | | ||
| | 53 | DNS | Name resolution | Always | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say also that this should be allowing the traffic in TCP and UDP, otherwise it could cause intermittent issues and disconnections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Added a Protocol column (TCP / TCP + UDP) to all port tables — Common Ingress, Common Egress, Worker Node Egress, and the firewall examples — so the required transport protocols are explicit throughout the document.
AI-assisted response via Claude Code
25b6bec to
3523791
Compare
|
Hey @bryan-cox I think it needs to execute verify in local and add the self-generated files from the execution to the commit :). Let me know for tagging 🙏 . |
3523791 to
35ef01d
Compare
Add comprehensive documentation for HCP networking port requirements including: - Common ingress/egress ports for all platforms - Platform-specific ports (AWS, Azure, IBM Cloud, PowerVS, KubeVirt, OpenStack, Agent, None) - Private cluster ports (AWS/Azure/GCP) - Konnectivity architecture overview with link to reference docs - Worker node egress requirements - Security considerations (TLS, source IP restrictions, sensitive data) - Firewall configuration examples All port references include code citations for verification. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
35ef01d to
70259f7
Compare
|
/verified bypass This is just docs |
|
@bryan-cox: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling required tests: |
|
@bryan-cox: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1463a78
into
openshift:main
Summary
Add comprehensive documentation for HCP networking port requirements to help operators configure firewalls and security groups.
Details
This PR adds
docs/content/how-to/common/hcp-networking-requirements.mdcovering:All port numbers include code references for verification.
Test plan
🤖 Generated with Claude Code