NO-JIRA: fix(test): add aws-node-termination-handler to safe-evict audited list

[csrwng]

Summary

• Add aws-node-termination-handler to the auditedAppList in the EnsurePodsWithEmptyDirPVsHaveSafeToEvictAnnotations e2e test
• The component uses the standard control plane component framework (NewDeploymentComponent), which automatically sets the cluster-autoscaler.kubernetes.io/safe-to-evict-local-volumes annotation on its pods
• Without this fix, the test fails because it expects non-audited pods to have no safe-to-evict volumes, but the component legitimately has them (tmp, token, cloud-token)

Fix this failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/7814/pull-ci-openshift-hypershift-main-e2e-aws/2027149274311036928

Test plan

• Verify EnsurePodsWithEmptyDirPVsHaveSafeToEvictAnnotations e2e test passes on AWS clusters with the termination handler enabled

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Added application configuration to test auditing utilities to support additional application validation scenarios in end-to-end testing.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Walkthrough

A single entry for "aws-node-termination-handler" was added to the auditedApps list in a test utility function.

Changes

Cohort / File(s)	Summary
Test Utility Update test/e2e/util/util.go	Added "aws-node-termination-handler" mapped to "app" in the auditedApps list within EnsurePodsWithEmptyDirPVsHaveSafeToEvictAnnotations function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality	❓ Inconclusive	Unable to examine test file - shell execution environment not available. Cannot assess test quality against custom check requirements.	Provide the modified test file content or access to the repository to perform quality assessment.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Stable And Deterministic Test Names	✅ Passed	The PR only adds an entry to auditedAppList map in the test body. The test title remains static and descriptive without dynamic content or generated identifiers.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding aws-node-termination-handler to a safe-evict audited list in test code.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@csrwng: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Add aws-node-termination-handler to the auditedAppList in the EnsurePodsWithEmptyDirPVsHaveSafeToEvictAnnotations e2e test
• The component uses the standard control plane component framework (NewDeploymentComponent), which automatically sets the cluster-autoscaler.kubernetes.io/safe-to-evict-local-volumes annotation on its pods
• Without this fix, the test fails because it expects non-audited pods to have no safe-to-evict volumes, but the component legitimately has them (tmp, token, cloud-token)

Fix this failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/7814/pull-ci-openshift-hypershift-main-e2e-aws/2027149274311036928

Test plan

• Verify EnsurePodsWithEmptyDirPVsHaveSafeToEvictAnnotations e2e test passes on AWS clusters with the termination handler enabled

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

[bryan-cox]

/verified by e2e

[openshift-ci-robot]

@bryan-cox: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[csrwng]

/retest-required

[cwbotbot]

Test Results

e2e-aws

• Status: ❌ FAIL
• Started: 2026-02-27T01:51:25Z
• View Job
• View Job History

Failed Tests

Total failed tests: 7

• TestNodePool
• TestNodePool/HostedCluster0
• TestNodePool/HostedCluster0/Main
• TestNodePool/HostedCluster0/Main/TestNTOMachineConfigAppliedInPlace
• TestNodePool/HostedCluster0/Main/TestNTOMachineConfigAppliedInPlace/EnsureNoCrashingPods

... and 2 more failed tests

e2e-aks

• Status: ✅ PASS
• Started: 2026-02-27T01:51:26Z
• View Job
• View Job History

[openshift-ci]

@csrwng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	e544e98	link	true	/test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.