CNTRLPLANE-2172: fix(e2e): register Azure private platform e2e flags#7977
Conversation
The CI runner passes --e2e.azure-private-credentials-file and --e2e.azure-pls-resource-group to the test binary, but these flags are not registered on main, causing the test to fail immediately with "flag provided but not defined". Add AzurePrivateCredentialsFile and AzurePLSResourceGroup to HyperShiftOperatorInstallOptions and register the corresponding e2e flags. JIRA: CNTRLPLANE-2172 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@bryan-cox: This pull request references CNTRLPLANE-2172 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes introduce two new Azure-related configuration fields to the test framework: ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
/area test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bryan-cox: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/verified bypass |
|
@bryan-cox: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bryan-cox: This pull request references CNTRLPLANE-2172 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
Test Resultse2e-aws
Failed TestsTotal failed tests: 3
e2e-aks
Failed TestsTotal failed tests: 3
|
|
/retest |
|
/override "ci/prow/e2e-aks" |
|
Overriding those tests as the failures are unrelated to these changes |
|
@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-aks, ci/prow/e2e-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "ci/prow/e2e-azure-self-managed" |
|
@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-azure-self-managed DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "ci/prow/e2e-azure-self-managed" |
|
@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-azure-self-managed DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
The CI runner in openshift/release#75998 passes
--e2e.azure-private-credentials-fileand--e2e.azure-pls-resource-groupto the test binary, but these flags are not registered on main, causing the test to fail immediately withflag provided but not defined.This was intended to be part of #7968 but was pushed after the PR had already merged.
Changes
AzurePrivateCredentialsFileandAzurePLSResourceGroupfields toHyperShiftOperatorInstallOptions--e2e.azure-private-credentials-fileand--e2e.azure-pls-resource-groupflags in e2e test initgetInstallOptions()Test plan
go build ./test/e2e/...compiles cleanlyJIRA: CNTRLPLANE-2172
🤖 Generated with Claude Code
Summary by CodeRabbit