Skip to content

CNTRLPLANE-2172: fix(e2e): register Azure private platform e2e flags#7977

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bryan-cox:fix-azure-e2e-flags
Mar 17, 2026
Merged

CNTRLPLANE-2172: fix(e2e): register Azure private platform e2e flags#7977
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bryan-cox:fix-azure-e2e-flags

Conversation

@bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Mar 16, 2026

Summary

The CI runner in openshift/release#75998 passes --e2e.azure-private-credentials-file and --e2e.azure-pls-resource-group to the test binary, but these flags are not registered on main, causing the test to fail immediately with flag provided but not defined.

This was intended to be part of #7968 but was pushed after the PR had already merged.

Changes

  • Add AzurePrivateCredentialsFile and AzurePLSResourceGroup fields to HyperShiftOperatorInstallOptions
  • Register --e2e.azure-private-credentials-file and --e2e.azure-pls-resource-group flags in e2e test init
  • Wire the new options to install options in getInstallOptions()

Test plan

  • go build ./test/e2e/... compiles cleanly
  • Rerun openshift/release#75998 rehearsal — test binary should accept the flags

JIRA: CNTRLPLANE-2172

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added support for Azure private credentials and Private Link Service resource group configuration options for HyperShift Operator installations in Azure environments.

The CI runner passes --e2e.azure-private-credentials-file and
--e2e.azure-pls-resource-group to the test binary, but these flags
are not registered on main, causing the test to fail immediately with
"flag provided but not defined".

Add AzurePrivateCredentialsFile and AzurePLSResourceGroup to
HyperShiftOperatorInstallOptions and register the corresponding
e2e flags.

JIRA: CNTRLPLANE-2172

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2026

@bryan-cox: This pull request references CNTRLPLANE-2172 which is a valid jira issue.

Details

In response to this:

Summary

The CI runner in openshift/release#75998 passes --e2e.azure-private-credentials-file and --e2e.azure-pls-resource-group to the test binary, but these flags are not registered on main, causing the test to fail immediately with flag provided but not defined.

This was intended to be part of #7968 but was pushed after the PR had already merged.

Changes

  • Add AzurePrivateCredentialsFile and AzurePLSResourceGroup fields to HyperShiftOperatorInstallOptions
  • Register --e2e.azure-private-credentials-file and --e2e.azure-pls-resource-group flags in e2e test init
  • Wire the new options to install options in getInstallOptions()

Test plan

  • go build ./test/e2e/... compiles cleanly
  • Rerun openshift/release#75998 rehearsal — test binary should accept the flags

JIRA: CNTRLPLANE-2172

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 930a82c0-97fc-4245-abf2-058e6643116f

📥 Commits

Reviewing files that changed from the base of the PR and between a0caff0 and 52c432c.

📒 Files selected for processing (3)
  • test/e2e/e2e_test.go
  • test/e2e/util/install.go
  • test/e2e/util/options.go

📝 Walkthrough

Walkthrough

The changes introduce two new Azure-related configuration fields to the test framework: AzurePrivateCredentialsFile and AzurePLSResourceGroup. These are added as CLI flags in the test entry point, propagated through the HyperShiftOperatorInstallOptions struct, and finally populated into the install.Options struct used during test setup. The modifications enable tests to accept and configure Azure private link service and credentials file parameters without altering existing control flow or error handling logic.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from jparrill and sjenning March 16, 2026 17:33
@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Mar 16, 2026
@bryan-cox
Copy link
Member Author

/area test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Mar 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@bryan-cox: The label(s) area/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

/area test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Member Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 16, 2026
@openshift-ci-robot
Copy link

@bryan-cox: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2026

@bryan-cox: This pull request references CNTRLPLANE-2172 which is a valid jira issue.

Details

In response to this:

Summary

The CI runner in openshift/release#75998 passes --e2e.azure-private-credentials-file and --e2e.azure-pls-resource-group to the test binary, but these flags are not registered on main, causing the test to fail immediately with flag provided but not defined.

This was intended to be part of #7968 but was pushed after the PR had already merged.

Changes

  • Add AzurePrivateCredentialsFile and AzurePLSResourceGroup fields to HyperShiftOperatorInstallOptions
  • Register --e2e.azure-private-credentials-file and --e2e.azure-pls-resource-group flags in e2e test init
  • Wire the new options to install options in getInstallOptions()

Test plan

  • go build ./test/e2e/... compiles cleanly
  • Rerun openshift/release#75998 rehearsal — test binary should accept the flags

JIRA: CNTRLPLANE-2172

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
  • Added support for Azure private credentials and Private Link Service resource group configuration options for HyperShift Operator installations in Azure environments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

@cwbotbot
Copy link

cwbotbot commented Mar 16, 2026

Test Results

e2e-aws

Failed Tests

Total failed tests: 3

  • TestUpgradeControlPlane
  • TestUpgradeControlPlane/Main
  • TestUpgradeControlPlane/Main/EnsureNoCrashingPods

e2e-aks

Failed Tests

Total failed tests: 3

  • TestUpgradeControlPlane
  • TestUpgradeControlPlane/Main
  • TestUpgradeControlPlane/Main/EnsureNoCrashingPods

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/override "ci/prow/e2e-aks"
/override "ci/prow/e2e-aws"

@bryan-cox
Copy link
Member Author

Overriding those tests as the failures are unrelated to these changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-aks, ci/prow/e2e-aws

Details

In response to this:

/override "ci/prow/e2e-aks"
/override "ci/prow/e2e-aws"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Member Author

/override "ci/prow/e2e-azure-self-managed"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-azure-self-managed

Details

In response to this:

/override "ci/prow/e2e-azure-self-managed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Member Author

/override "ci/prow/e2e-azure-self-managed"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-azure-self-managed

Details

In response to this:

/override "ci/prow/e2e-azure-self-managed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6766813 into openshift:main Mar 17, 2026
23 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants