Skip to content

OCPSTRAT-2831: chore(owners): add cblecker to core-reviewers and core-approvers#8018

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
cblecker:chore/add-cblecker-to-owners
Mar 25, 2026
Merged

OCPSTRAT-2831: chore(owners): add cblecker to core-reviewers and core-approvers#8018
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
cblecker:chore/add-cblecker-to-owners

Conversation

@cblecker
Copy link
Member

@cblecker cblecker commented Mar 19, 2026

Summary

  • Add cblecker to core-reviewers and core-approvers groups to assist with PR reviews relating to GCP and e2e efforts.

This is a result of a discussion with @celebdor and @sjenning. This is pending a guidelines agreement from the Hypershift team.

Note that #8009 ensures this wouldn't allow for API changes without more review.

Summary by CodeRabbit

  • Chores
    • Updated core team ownership and review permissions configuration.

Adding cblecker to core-reviewers and core-approvers groups to assist
with PR reviews relating to GCP and e2e efforts.

Assisted-by: Claude:claude-opus-4-6
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d7a2b86f-86e0-4d26-a451-dfa1f230d335

📥 Commits

Reviewing files that changed from the base of the PR and between b429fb3 and ada1ac5.

📒 Files selected for processing (1)
  • OWNERS_ALIASES

📝 Walkthrough

Walkthrough

The pull request updates the OWNERS_ALIASES file by adding cblecker to two existing alias lists. Specifically, cblecker is appended to the core-approvers alias and the core-reviewers alias. This change expands the membership of these two designated roles, enabling cblecker to be included in approval and review processes governed by these aliases. The modification results in 2 lines added with no lines removed.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@cblecker
Copy link
Member Author

/cc @celebdor @sjenning

@cblecker cblecker marked this pull request as ready for review March 19, 2026 18:25
@openshift-ci openshift-ci bot requested review from celebdor and sjenning March 19, 2026 18:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2026
@openshift-ci openshift-ci bot requested review from bryan-cox and muraee March 19, 2026 18:25
@cblecker
Copy link
Member Author

/area documentation

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Mar 19, 2026
@cblecker
Copy link
Member Author

/uncc bryan-cox muraee

@openshift-ci openshift-ci bot removed request for bryan-cox and muraee March 19, 2026 18:26
@cblecker
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2026
@openshift-ci-robot
Copy link

@cblecker: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cblecker
Copy link
Member Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 19, 2026
@openshift-ci-robot
Copy link

@cblecker: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cblecker
Copy link
Member Author

/area platform/gcp

@openshift-ci openshift-ci bot added the area/platform/gcp PR/issue for GCP (GCPPlatform) platform label Mar 19, 2026
@cblecker cblecker changed the title chore(owners): add cblecker to core-reviewers and core-approvers OCPSTRAT-2831: chore(owners): add cblecker to core-reviewers and core-approvers Mar 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2026

@cblecker: This pull request references OCPSTRAT-2831 which is a valid jira issue.

Details

In response to this:

Summary

  • Add cblecker to core-reviewers and core-approvers groups to assist with PR reviews relating to GCP and e2e efforts.

This is a result of a discussion with @celebdor and @sjenning. This is pending a guidelines agreement from the Hypershift team.

Summary by CodeRabbit

  • Chores
  • Updated core team ownership and review permissions configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2026

@cblecker: This pull request references OCPSTRAT-2831 which is a valid jira issue.

Details

In response to this:

Summary

  • Add cblecker to core-reviewers and core-approvers groups to assist with PR reviews relating to GCP and e2e efforts.

This is a result of a discussion with @celebdor and @sjenning. This is pending a guidelines agreement from the Hypershift team.

Note that #8009 ensures this wouldn't allow for API changes without more review.

Summary by CodeRabbit

  • Chores
  • Updated core team ownership and review permissions configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjenning
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2026
@sjenning
Copy link
Contributor

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced
/override ci/prow/e2e-v2-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2026

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced, ci/prow/e2e-v2-aws

Details

In response to this:

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced
/override ci/prow/e2e-v2-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cblecker
Copy link
Member Author

/hold cancel

Thanks Seth!

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2026
@cwbotbot
Copy link

cwbotbot commented Mar 24, 2026

Test Results

e2e-aws

e2e-aks

@cblecker
Copy link
Member Author

/retest-required

1 similar comment
@cblecker
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2026

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2fc70ab into openshift:main Mar 25, 2026
21 checks passed
@cblecker cblecker deleted the chore/add-cblecker-to-owners branch March 25, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation area/platform/gcp PR/issue for GCP (GCPPlatform) platform jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants