Skip to content

NO-JIRA: feat(e2e): add Azure platform support for backup/restore tests#8144

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mgencur:backup_restore_aks
Apr 6, 2026
Merged

NO-JIRA: feat(e2e): add Azure platform support for backup/restore tests#8144
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mgencur:backup_restore_aks

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented Apr 1, 2026

What this PR does / why we need it:

Enable backup/restore e2e tests to run on AzurePlatform by adding it
to the backupRestorePlatforms with no post-restore hook.

Which issue(s) this PR fixes:

Related to https://redhat.atlassian.net/browse/CNTRLPLANE-2033

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Note

Low Risk
Low risk: test-only change that just extends platform gating/configuration and does not affect production code paths.

Overview
Backup/restore e2e tests now recognize hyperv1.AzurePlatform by adding it to backupRestorePlatforms with the same workload exclusions as Agent/KubeVirt and no post-restore hook, allowing the suite to run (instead of skipping) on Azure clusters.

Written by Cursor Bugbot for commit 5e9e503. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Tests
    • Enhanced backup and restore test coverage for Azure-hosted clusters so the suite runs on Azure instead of being skipped; tests now apply specific workload exclusions during control-plane readiness and restore validations.

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mgencur: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

Enable backup/restore e2e tests to run on AzurePlatform by adding it to the backupRestorePlatforms map with the same exclusions as Agent (no karpenter, no cloud-network-config-controller) and no post-restore hook.

Which issue(s) this PR fixes:

Related to https://redhat.atlassian.net/browse/CNTRLPLANE-2033

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7c551492-289d-40ea-a39e-357af7b1e63f

📥 Commits

Reviewing files that changed from the base of the PR and between 5e9e503 and ddc502d.

📒 Files selected for processing (1)
  • test/e2e/v2/tests/backup_restore_test.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/e2e/v2/tests/backup_restore_test.go

📝 Walkthrough

Walkthrough

This change extends the backup_restore_test.go test suite to support the Azure platform by adding hyperv1.AzurePlatform to the backupRestorePlatforms map with excludeWorkloads set to ["router","karpenter","karpenter-operator"] and postRestoreHook set to nil. As a result, the test's BeforeAll platform selection logic will recognize Azure and apply the specified workload exclusions instead of skipping Azure-based hosted cluster tests.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from bryan-cox and cblecker April 1, 2026 09:07
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Apr 1, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Enable backup/restore e2e tests to run on AzurePlatform by adding it
to the backupRestorePlatforms with no post-restore hook.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mgencur mgencur force-pushed the backup_restore_aks branch from 5e9e503 to ddc502d Compare April 1, 2026 09:20
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.89%. Comparing base (9f96a0f) to head (ddc502d).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8144   +/-   ##
=======================================
  Coverage   29.89%   29.89%           
=======================================
  Files        1050     1050           
  Lines       97819    97819           
=======================================
  Hits        29240    29240           
  Misses      66075    66075           
  Partials     2504     2504           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026
@jparrill
Copy link
Copy Markdown
Contributor

jparrill commented Apr 6, 2026

/verified by tests

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jparrill: This PR has been marked as verified by tests.

Details

In response to this:

/verified by tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@LiangquanLi930
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 51af991 and 2 for PR HEAD ddc502d in total

@cwbotbot
Copy link
Copy Markdown

cwbotbot commented Apr 6, 2026

Test Results

e2e-aws

e2e-aks

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bcf6ada into openshift:main Apr 6, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants