Skip to content

NO-JIRA: ci: ignore non-Go files in codecov coverage analysis#8154

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bryan-cox:codecov-ignore-non-go
Apr 2, 2026
Merged

NO-JIRA: ci: ignore non-Go files in codecov coverage analysis#8154
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bryan-cox:codecov-ignore-non-go

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented Apr 2, 2026

Summary

  • Adds non-Go files to the codecov ignore list to prevent false codecov/project failures on PRs that only modify non-source files
  • Ignored paths: Makefile, dot directories (.*/**), dotfiles (.*), and common non-Go extensions (*.md, *.yaml, *.yml, *.mod, *.sum)

Test plan

Summary by CodeRabbit

  • Chores
    • Updated code coverage configuration to refine coverage analysis.

Adds Makefile, dot directories, and common non-Go file extensions
(*.md, *.yaml, *.yml, *.mod, *.sum, .*) to the codecov ignore list.
These files have no unit test coverage and cause false codecov/project
failures on PRs that only modify non-Go files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Adds non-Go files to the codecov ignore list to prevent false codecov/project failures on PRs that only modify non-source files
  • Ignored paths: Makefile, dot directories (.*/**), dotfiles (.*), and common non-Go extensions (*.md, *.yaml, *.yml, *.mod, *.sum)

Test plan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c920c319-6170-4d3b-89ba-526fc629dd25

📥 Commits

Reviewing files that changed from the base of the PR and between e087807 and 0151d55.

📒 Files selected for processing (1)
  • codecov.yml

📝 Walkthrough

Walkthrough

The codecov.yml file was modified to extend the coverage ignore patterns in the Codecov configuration. Added exclusion rules for non-code files and directories including: Makefile, all dot-prefixed directories with nested content (.*/**), Markdown files (*.md), YAML configuration files (*.yaml and *.yml), Go module-related files (*.mod and *.sum), and all dotfiles and dot-prefixed directories (.*). These changes prevent these file types from being considered in code coverage calculations.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@openshift-ci openshift-ci bot requested review from enxebre and jparrill April 2, 2026 15:51
@bryan-cox
Copy link
Copy Markdown
Member Author

/area ci-tooling

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Apr 2, 2026
@sjenning
Copy link
Copy Markdown
Contributor

sjenning commented Apr 2, 2026

/lgtm

@bryan-cox
Copy link
Copy Markdown
Member Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.36%. Comparing base (c54e7af) to head (0151d55).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8154      +/-   ##
==========================================
- Coverage   29.96%   27.36%   -2.61%     
==========================================
  Files        1049     1096      +47     
  Lines       97523   107254    +9731     
==========================================
+ Hits        29225    29346     +121     
- Misses      65796    75390    +9594     
- Partials     2502     2518      +16     

see 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bryan-cox
Copy link
Copy Markdown
Member Author

/override "codecov/project"

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@bryan-cox: Overrode contexts on behalf of bryan-cox: codecov/project

Details

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 932c5a3 into openshift:main Apr 2, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants