NO-JIRA: ci: fix codecov ignore patterns for docs and nested files#8156
Conversation
The existing glob patterns (*.md, *.yaml, *.yml) only match files at the repository root. Use **/*.md and **/*.yml patterns to match files in subdirectories, and explicitly add docs/** to ensure the entire documentation directory is excluded from coverage analysis. Signed-off-by: Bryan Cox <brcox@redhat.com> Commit-Message-Assisted-by: Claude (via Claude Code)
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the Codecov configuration file ( ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@bryan-cox: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/area ci-tooling |
|
/lgtm |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8156 +/- ##
=======================================
Coverage 27.36% 27.36%
=======================================
Files 1096 1096
Lines 107266 107266
=======================================
Hits 29357 29357
Misses 75391 75391
Partials 2518 2518 🚀 New features to boost your workflow:
|
|
/verified bypass |
|
@bryan-cox: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Fixes codecov ignore patterns that only matched root-level files:
*.md→**/*.md(matches markdown files in all subdirectories)*.yaml→**/*.yaml(matches yaml files in all subdirectories)*.yml→**/*.yml(matches yml files in all subdirectories)docs/**to explicitly exclude the entire documentation directoryWithout this, docs-only PRs (e.g. changes to
docs/content/) can trigger spurious codecov project coverage failures.Which issue(s) this PR fixes:
Special notes for your reviewer:
codecov.ymlis read from the default branch (main), so these changes won't take effect until merged.Checklist:
Summary by CodeRabbit