Skip to content

NO-JIRA: ci: fix codecov ignore patterns for docs and nested files#8156

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bryan-cox:fix-codecov-ignore-docs
Apr 2, 2026
Merged

NO-JIRA: ci: fix codecov ignore patterns for docs and nested files#8156
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bryan-cox:fix-codecov-ignore-docs

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented Apr 2, 2026

What this PR does / why we need it:

Fixes codecov ignore patterns that only matched root-level files:

  • *.md**/*.md (matches markdown files in all subdirectories)
  • *.yaml**/*.yaml (matches yaml files in all subdirectories)
  • *.yml**/*.yml (matches yml files in all subdirectories)
  • Adds docs/** to explicitly exclude the entire documentation directory

Without this, docs-only PRs (e.g. changes to docs/content/) can trigger spurious codecov project coverage failures.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov.yml is read from the default branch (main), so these changes won't take effect until merged.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • Chores
    • Updated code coverage configuration to exclude documentation files and expand pattern matching rules for more accurate coverage reporting.

The existing glob patterns (*.md, *.yaml, *.yml) only match files at
the repository root. Use **/*.md and **/*.yml patterns to match files
in subdirectories, and explicitly add docs/** to ensure the entire
documentation directory is excluded from coverage analysis.

Signed-off-by: Bryan Cox <brcox@redhat.com>
Commit-Message-Assisted-by: Claude (via Claude Code)
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9d52af1b-2598-4693-9f46-464199de3362

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa4e8a and 5a43be2.

📒 Files selected for processing (1)
  • codecov.yml

📝 Walkthrough

Walkthrough

The pull request updates the Codecov configuration file (codecov.yml) to modify the code coverage ignore patterns. The changes expand the coverage exclusion rules by adding a pattern to ignore all files under the docs/** directory and converting root-level file pattern globs (*.md, *.yaml, *.yml) into recursive patterns (**/*.md, **/*.yaml, **/*.yml). This ensures that Markdown and YAML files at any directory depth, as well as all documentation files, are excluded from code coverage calculations. No functional code changes are introduced.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bryan-cox bryan-cox changed the title ci: fix codecov ignore patterns for docs and nested files NO-JIRA: ci: fix codecov ignore patterns for docs and nested files Apr 2, 2026
@openshift-ci openshift-ci bot requested review from enxebre and muraee April 2, 2026 17:40
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

Fixes codecov ignore patterns that only matched root-level files:

  • *.md**/*.md (matches markdown files in all subdirectories)
  • *.yaml**/*.yaml (matches yaml files in all subdirectories)
  • *.yml**/*.yml (matches yml files in all subdirectories)
  • Adds docs/** to explicitly exclude the entire documentation directory

Without this, docs-only PRs (e.g. changes to docs/content/) can trigger spurious codecov project coverage failures.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov.yml is read from the default branch (main), so these changes won't take effect until merged.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@bryan-cox
Copy link
Copy Markdown
Member Author

/area ci-tooling

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Apr 2, 2026
@sjenning
Copy link
Copy Markdown
Contributor

sjenning commented Apr 2, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.36%. Comparing base (2aa4e8a) to head (5a43be2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8156   +/-   ##
=======================================
  Coverage   27.36%   27.36%           
=======================================
  Files        1096     1096           
  Lines      107266   107266           
=======================================
  Hits        29357    29357           
  Misses      75391    75391           
  Partials     2518     2518           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bryan-cox
Copy link
Copy Markdown
Member Author

/verified bypass

@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5699280 into openshift:main Apr 2, 2026
20 checks passed
@bryan-cox bryan-cox deleted the fix-codecov-ignore-docs branch April 2, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants