[release-4.20] OCPBUGS-83711: fix(kubevirt): filter link-local addresses from EndpointSlice endpoints#8271
Conversation
KubeVirt VMs can report link-local addresses (169.254.0.0/16, fe80::/10) in Machine.Status.Addresses. Kubernetes 1.33 added validation that rejects link-local addresses in EndpointSlices, causing the HCCO machine reconciler to fail when creating EndpointSlices for guest LoadBalancer shadow services. The early return on error also prevented processing of subsequent KCCM shadow services. Filter out link-local addresses using netip.Addr.IsLinkLocalUnicast() before populating EndpointSlice endpoints. Signed-off-by: Oren Cohen <ocohen@redhat.com> Assisted-by: Claude
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-83604 with correct target version. Will retitle the PR to link to the clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-83711, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #8264
/assign openshift-ci-robot