NO_JIRA: ci(gha): add release-4.23 branch to unit test workflow (expect verify-workflows PASS)

[bryan-cox]

Summary

• Test PR to verify the verify-workflows presubmit from openshift/release#77164
• This branch is based on current main and intentionally modifies a GHA workflow file (.github/workflows/test.yaml)
• The ci/prow/verify-workflows check should PASS on this PR because the workflow change is intentional (hash differs from both main and merge-base)

Changes

• Added release-4.23 to the push and pull_request branch filters in the unit test workflow

Expected behavior

The verify-workflows presubmit should detect that the workflow file was intentionally modified and pass.

Test plan

• Verify ci/prow/verify-workflows passes on this PR
• Close PR after verification (do not merge)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Updated internal testing infrastructure to support additional release branches.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 03e02e18-8640-488f-8c04-af1f3acc9d39

📥 Commits

Reviewing files that changed from the base of the PR and between 5c06422 and 2087cfa.

📒 Files selected for processing (1)

• .github/workflows/test.yaml

---

📝 Walkthrough

Walkthrough

The test workflow in .github/workflows/test.yaml was updated to include the release-4.23 branch as a trigger condition for both push and pull_request events. Previously, the workflow was triggered only for the main and release-4.22 branches. This change extends automated testing coverage to the new release branch while keeping all other workflow steps, job configurations, and conditional logic intact.

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding the release-4.23 branch to the unit test workflow trigger conditions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	PR only modifies .github/workflows/test.yaml, a CI/CD workflow file. No Ginkgo test definitions or test names are added or modified.
Test Structure And Quality	✅ Passed	The custom check for Ginkgo test code quality is not applicable to this PR. The PR exclusively modifies .github/workflows/test.yaml, a GitHub Actions workflow configuration file. No Ginkgo test files or test code are modified.
Microshift Test Compatibility	✅ Passed	The MicroShift Test Compatibility check is not applicable because no new Ginkgo e2e tests are being added; only a GitHub Actions workflow configuration file is modified.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only modifies .github/workflows/test.yaml to add the release-4.23 branch to GitHub Actions workflow trigger conditions. No new Ginkgo e2e tests are being added, so the custom check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR only modifies .github/workflows/test.yaml, a CI/CD configuration file with no Kubernetes deployment, operator, or scheduling constraint changes.
Ote Binary Stdout Contract	✅ Passed	The custom check regarding OTE Binary Stdout Contract is not applicable to this pull request. The PR exclusively modifies .github/workflows/test.yaml, a GitHub Actions workflow configuration file written in YAML that simply adds the release-4.23 branch to CI trigger conditions. The check is designed to prevent unintended stdout writes in Go process-level code (main(), init(), TestMain(), test suites, etc.) that would corrupt OTE binary communication. Since this PR contains no source code changes, test implementations, or executable code that could violate the stdout contract, the check does not apply.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies the .github/workflows/test.yaml file to add the release-4.23 branch to the unit test workflow triggers. No new Ginkgo e2e tests or Go test files are being introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Please specify an area label

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hypershift-jira-solve-ci]

I now have the complete picture. Here is the analysis:

Test Failure Analysis Complete

Job Information

• Prow Job: Gitlint (GitHub Actions)
• Build ID: 24664416934 / job 72118278300
• Repository: openshift/hypershift
• PR: NO_JIRA: ci(gha): add release-4.23 branch to unit test workflow (expect verify-workflows PASS) #8284

Test Failure Analysis

Error

1: CT1 Title does not start with one of fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build:
"NO_JIRA: ci(gha): add release-4.23 branch to unit test workflow"

Summary

The Gitlint check enforces Conventional Commits format on commit message titles. The commit title starts with NO_JIRA: instead of a valid conventional commit type prefix. The repo's .gitlint configuration requires titles to begin with one of: fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build. The ci(gha): portion is the correct prefix but it is preceded by NO_JIRA:, which violates the rule.

Root Cause

The commit message title is:

NO_JIRA: ci(gha): add release-4.23 branch to unit test workflow

The repository's .gitlint configuration (contrib-title-conventional-commits) requires the title to start with a conventional commit type. The NO_JIRA: prefix precedes the valid ci(gha): conventional commit type, causing the CT1 rule violation.

The .gitlint config at the repo root explicitly defines:

[contrib-title-conventional-commits]
types = fix,feat,chore,docs,style,refactor,perf,test,revert,ci,build

The gitlint CT1 rule performs a prefix match — the very first characters of the title must be one of the allowed types. NO_JIRA: is not in that list, so the check fails immediately.

Recommendations

1. Amend the commit message to move the conventional commit type to the front:

   ci(gha): add release-4.23 branch to unit test workflow
   

   The NO_JIRA tag is not needed in the title — the PR title already conveys JIRA status, and the commit body or PR description can note it if required.

2. If a JIRA reference is required, place it in the commit body or as a trailer, not in the title prefix:

   ci(gha): add release-4.23 branch to unit test workflow
   
   NO_JIRA
   

3. Force-push the amended commit to the PR branch to re-trigger the Gitlint check.

Evidence

Evidence	Detail
Failed Rule	CT1 (contrib-title-conventional-commits)
Error Message	Title does not start with one of fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build
Commit Title	NO_JIRA: ci(gha): add release-4.23 branch to unit test workflow
Config File	.gitlint — contrib=contrib-title-conventional-commits, types = fix,feat,chore,docs,style,refactor,perf,test,revert,ci,build
Expected Format	ci(gha): add release-4.23 branch to unit test workflow
GHA Job	Gitlint in workflow run 24664416934, job 72118278300

---

[bryan-cox]

/retest verify-workflows

[bryan-cox]

/test verify-workflows

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bryan-cox]

Verified: verify-workflows check passes for intentional workflow changes. Closing test PR.