[release-4.22] OCPBUGS-83836: add missing RBAC for webhook configurations by openshift-cherrypick-robot · Pull Request #8295 · openshift/hypershift

openshift-cherrypick-robot · 2026-04-21T08:43:35Z

This is an automated cherry-pick of #8276

/assign celebdor

The webhookcerts controller introduced in PR openshift#8174 (CNTRLPLANE-2207) performs Get/Update on MutatingWebhookConfiguration and ValidatingWebhookConfiguration via the cached client, which triggers lazy informer creation requiring list/watch at cluster scope. The ClusterRole was missing these permissions, causing repeated reflector errors in the operator logs. Add a cluster-scoped RBAC rule for mutatingwebhookconfigurations and validatingwebhookconfigurations with get, list, watch, and update verbs. Closes: OCPBUGS-83751 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>

coderabbitai · 2026-04-21T08:43:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 94b71edd-6bd5-4948-a0f3-ae6e455390a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-04-21T08:44:47Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-83751 has been cloned as Jira Issue OCPBUGS-83836. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-83836: add missing RBAC for webhook configurations

Details

In response to this:

This is an automated cherry-pick of #8276

/assign celebdor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-21T08:44:59Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-83836, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #8276

/assign celebdor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-04-21T08:58:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.95%. Comparing base (293c70e) to head (3555ea3).
⚠️ Report is 36 commits behind head on release-4.22.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22    #8295      +/-   ##
================================================
+ Coverage         34.64%   34.95%   +0.31%     
================================================
  Files               767      767              
  Lines             93192    93197       +5     
================================================
+ Hits              32284    32579     +295     
+ Misses            58233    57940     -293     
- Partials           2675     2678       +3

Files with missing lines	Coverage Δ
cmd/install/assets/hypershift_operator.go	`43.61% <100.00%> (+14.92%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

enxebre · 2026-04-23T12:49:14Z

/approve
/lgtm

enxebre · 2026-04-23T12:50:52Z

/jira refresh

openshift-ci-robot · 2026-04-23T12:51:00Z

@enxebre: This pull request references Jira Issue OCPBUGS-83836, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-83751 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-83751 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

enxebre · 2026-04-23T12:52:44Z

/test e2e-kubevirt-aws-ovn-reduced

enxebre · 2026-04-23T12:54:08Z

/approve
/lgtm

openshift-ci · 2026-04-23T12:57:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jparrill · 2026-04-24T07:36:54Z

/retest-required

mgencur · 2026-04-24T07:46:48Z

/test e2e-aws
/test e2e-aks

jparrill · 2026-04-24T08:04:25Z

/retest-required

jparrill · 2026-04-27T07:27:46Z

/retest-required

jparrill · 2026-04-27T16:13:16Z

/retest-required

jparrill · 2026-04-29T14:28:32Z

/retest

jparrill · 2026-05-20T10:06:31Z

/retest-required

jparrill · 2026-05-20T10:11:28Z

/verified by e2e artifacts

openshift-ci-robot · 2026-05-20T10:11:40Z

@jparrill: This PR has been marked as verified by e2e artifacts.

Details

In response to this:

/verified by e2e artifacts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-05-20T14:04:30Z

/retest-required

Remaining retests: 0 against base HEAD 0004926 and 2 for PR HEAD 3555ea3 in total

openshift-ci · 2026-05-20T16:36:25Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-05-20T16:42:44Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-83836
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-83836 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #8276

/assign celebdor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot assigned celebdor Apr 21, 2026

openshift-cherrypick-robot mentioned this pull request Apr 21, 2026

OCPBUGS-83751: add missing RBAC for webhook configurations #8276

Merged

3 tasks

openshift-ci Bot added the do-not-merge/needs-area label Apr 21, 2026

openshift-ci Bot requested review from csrwng and enxebre April 21, 2026 08:44

openshift-ci Bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Apr 21, 2026

openshift-ci Bot changed the title ~~[release-4.22] OCPBUGS-83751: add missing RBAC for webhook configurations~~ [release-4.22] OCPBUGS-83836: add missing RBAC for webhook configurations Apr 21, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 21, 2026

This was referenced Apr 21, 2026

OCPBUGS-81686: fix(authentication): use v2 auth validation for CEL and expression support. #8246

Merged

OCPBUGS-75887: fix(inplaceupgrader): include node name in degraded upgrade error message #8244

Merged

enxebre added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 23, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 23, 2026

openshift-ci Bot assigned enxebre Apr 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2026

mgencur mentioned this pull request Apr 24, 2026

NO-JIRA: Install MetalLB from konflux in MCE jobs openshift/release#78236

Merged

mgencur mentioned this pull request May 12, 2026

Backup/restore tests for Agent and Kubevirt platform openshift/release#76214

Open

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 20, 2026

openshift-merge-bot Bot merged commit a62f7c3 into openshift:release-4.22 May 20, 2026
20 checks passed

Conversation

openshift-cherrypick-robot commented Apr 21, 2026

Uh oh!

coderabbitai Bot commented Apr 21, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Apr 21, 2026

Uh oh!

openshift-ci-robot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

enxebre commented Apr 23, 2026

Uh oh!

enxebre commented Apr 23, 2026

Uh oh!

openshift-ci-robot commented Apr 23, 2026

Uh oh!

enxebre commented Apr 23, 2026

Uh oh!

enxebre commented Apr 23, 2026

Uh oh!

openshift-ci Bot commented Apr 23, 2026

Uh oh!

jparrill commented Apr 24, 2026

Uh oh!

mgencur commented Apr 24, 2026

Uh oh!

jparrill commented Apr 24, 2026

Uh oh!

jparrill commented Apr 27, 2026

Uh oh!

jparrill commented Apr 27, 2026

Uh oh!

jparrill commented Apr 29, 2026

Uh oh!

jparrill commented May 20, 2026

Uh oh!

jparrill commented May 20, 2026

Uh oh!

openshift-ci-robot commented May 20, 2026

Uh oh!

openshift-merge-bot Bot commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Apr 21, 2026 •

edited

Loading