[release-4.15] OCPBUGS-84183: fix(cno): use brackets only for IPv6 in server URL by sdodson · Pull Request #8308 · openshift/hypershift

sdodson · 2026-04-22T19:49:32Z

Summary

Backport of [release-4.20] OCPBUGS-73365: fix(cno): use brackets only for IPv6 in server URL #7461 to release-4.15
The rewrite-config init container was unconditionally wrapping KUBERNETES_SERVICE_HOST in brackets, creating URLs like https://[172.29.0.1]:443. Go 1.24.8+ (CVE-2025-47912) now rejects IPv4 addresses in brackets per RFC 3986.
Uses a case statement to detect IPv6 (contains colon) and only add brackets for those addresses.

Fixes: https://issues.redhat.com/browse/OCPBUGS-72411

Test plan

UPDATE=true make test regenerated fixtures successfully
CI passes on release-4.15 branch

🤖 Generated with Claude Code

The rewrite-config init container was unconditionally wrapping KUBERNETES_SERVICE_HOST in brackets, creating URLs like https://[172.29.0.1]:443. Go 1.24.8+ (CVE-2025-47912) now rejects IPv4 addresses in brackets per RFC 3986. Use a case statement to detect IPv6 (contains colon) and only add brackets for those addresses. Fixes: https://issues.redhat.com/browse/OCPBUGS-72411 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Scott Dodson <sdodson@redhat.com>

openshift-ci-robot · 2026-04-22T19:49:39Z

@sdodson: This pull request references Jira Issue OCPBUGS-72411, which is invalid:

expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.22.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
dependent bug CNTRLPLANE-2465 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of [release-4.20] OCPBUGS-73365: fix(cno): use brackets only for IPv6 in server URL #7461 to release-4.15

The rewrite-config init container was unconditionally wrapping KUBERNETES_SERVICE_HOST in brackets, creating URLs like https://[172.29.0.1]:443. Go 1.24.8+ (CVE-2025-47912) now rejects IPv4 addresses in brackets per RFC 3986.

Uses a case statement to detect IPv6 (contains colon) and only add brackets for those addresses.

Fixes: https://issues.redhat.com/browse/OCPBUGS-72411

Test plan

UPDATE=true make test regenerated fixtures successfully

CI passes on release-4.15 branch

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-22T19:49:41Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 069b1e8b-0deb-4a5c-a00c-8d0df1e8baae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-04-22T20:00:56Z

@sdodson: This pull request references Jira Issue OCPBUGS-84183, which is invalid:

expected dependent Jira Issue OCPBUGS-84182 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of [release-4.20] OCPBUGS-73365: fix(cno): use brackets only for IPv6 in server URL #7461 to release-4.15

The rewrite-config init container was unconditionally wrapping KUBERNETES_SERVICE_HOST in brackets, creating URLs like https://[172.29.0.1]:443. Go 1.24.8+ (CVE-2025-47912) now rejects IPv4 addresses in brackets per RFC 3986.

Uses a case statement to detect IPv6 (contains colon) and only add brackets for those addresses.

Fixes: https://issues.redhat.com/browse/OCPBUGS-72411

Test plan

UPDATE=true make test regenerated fixtures successfully

CI passes on release-4.15 branch

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sdodson · 2026-04-22T20:08:13Z

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance #8308 openshift/cluster-network-operator/#2970

openshift-ci · 2026-04-22T20:08:17Z

@sdodson: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message.


unable to get additional pr info from string: openshift/cluster-network-operator/#2970: string: openshift/cluster-network-operator/#2970 doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

sdodson · 2026-04-22T20:08:19Z

/test ?

sdodson · 2026-04-22T20:09:23Z

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance #8308 openshift/cluster-network-operator#2970

openshift-ci · 2026-04-22T20:09:30Z

@sdodson: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/287688c0-3e87-11f1-979a-19907761e01e-0

openshift-ci · 2026-04-22T20:09:35Z

@sdodson: This PR was included in a payload test run from #8308
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/287688c0-3e87-11f1-979a-19907761e01e-0

sdodson · 2026-04-22T20:10:10Z

/test e2e-conformance
expecting this one to fail

sdodson · 2026-04-22T22:30:29Z

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance openshift/cluster-network-operator#2970

openshift-ci · 2026-04-22T22:30:33Z

@sdodson: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/de90e700-3e9a-11f1-95d3-dec0e015a1a8-0

devguyio · 2026-04-27T15:13:12Z

/retest-required

devguyio · 2026-04-29T08:35:01Z

/retest-required
/lgtm

devguyio · 2026-04-29T08:35:21Z

/approve
/lgtm cancel

devguyio · 2026-04-29T08:36:33Z

/lgtm

I'm not an approver on that branch. @muraee can you PTAL?

muraee · 2026-04-29T08:51:51Z

/retitle [release-4.15] OCPBUGS-84183: fix(cno): use brackets only for IPv6 in server URL

muraee · 2026-04-29T08:51:55Z

/approve

openshift-ci · 2026-04-29T08:52:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [muraee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2026-04-29T11:25:22Z

/lgtm

devguyio · 2026-04-30T08:03:47Z

/verified by e2e
/jira refresh

openshift-ci-robot · 2026-04-30T08:04:03Z

@devguyio: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-30T08:04:08Z

@devguyio: This pull request references Jira Issue OCPBUGS-84183, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-84182 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-84182 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
bug has dependents

Requesting review from QA contact:
/cc @sdodson

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/verified by e2e
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-30T08:04:20Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sdodson.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@devguyio: This pull request references Jira Issue OCPBUGS-84183, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.15.z) matches configured target version for branch (4.15.z)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

release note text is set and does not match the template

dependent bug Jira Issue OCPBUGS-84182 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))

dependent Jira Issue OCPBUGS-84182 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z

bug has dependents

Requesting review from QA contact:
/cc @sdodson

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/verified by e2e
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

devguyio · 2026-04-30T08:07:51Z

/retest-required

openshift-merge-bot · 2026-04-30T10:31:28Z

/retest-required

Remaining retests: 0 against base HEAD e1d4abe and 2 for PR HEAD a84551e in total

enxebre · 2026-04-30T13:12:18Z

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

This is exercising a selfhosted non supported permutation 4.15 management with latest HO

openshift-ci · 2026-04-30T13:12:44Z

@enxebre: Overrode contexts on behalf of enxebre: ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

This is exercising a selfhosted non supported permutation 4.15 management with latest HO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-04-30T13:12:46Z

@sdodson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-conformance	`a84551e`	link	false	`/test e2e-conformance`
ci/prow/e2e-kubevirt-aws-ovn-reduced	`a84551e`	link	true	`/test e2e-kubevirt-aws-ovn-reduced`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-04-30T13:17:16Z

@sdodson: Jira Issue OCPBUGS-84183: Some pull requests linked via external trackers have merged:

openshift/hypershift#8308

The following pull request, linked via external tracker, has not merged:

openshift/cluster-network-operator#2982 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-84183 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Summary

Backport of [release-4.20] OCPBUGS-73365: fix(cno): use brackets only for IPv6 in server URL #7461 to release-4.15

The rewrite-config init container was unconditionally wrapping KUBERNETES_SERVICE_HOST in brackets, creating URLs like https://[172.29.0.1]:443. Go 1.24.8+ (CVE-2025-47912) now rejects IPv4 addresses in brackets per RFC 3986.

Uses a case statement to detect IPv6 (contains colon) and only add brackets for those addresses.

Fixes: https://issues.redhat.com/browse/OCPBUGS-72411

Test plan

UPDATE=true make test regenerated fixtures successfully

CI passes on release-4.15 branch

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 22, 2026

openshift-ci Bot added the do-not-merge/needs-area label Apr 22, 2026

openshift-ci Bot requested review from isco-rodriguez and sjenning April 22, 2026 19:49

openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Apr 22, 2026

sdodson changed the title ~~OCPBUGS-72411: fix(cno): use brackets only for IPv6 in server URL~~ OCPBUGS-84183: fix(cno): use brackets only for IPv6 in server URL Apr 22, 2026

openshift-ci Bot mentioned this pull request Apr 22, 2026

CLOSE-ME-NOT-MERGE: fix(hypershift): use net.JoinHostPort for URL construction openshift/cluster-network-operator#2970

Closed

2 tasks

openshift-ci Bot assigned devguyio Apr 29, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026

openshift-ci Bot changed the title ~~OCPBUGS-84183: fix(cno): use brackets only for IPv6 in server URL~~ [release-4.15] OCPBUGS-84183: fix(cno): use brackets only for IPv6 in server URL Apr 29, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026

openshift-ci Bot assigned enxebre Apr 29, 2026

enxebre added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 30, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 30, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2026

openshift-merge-bot Bot merged commit 4f79410 into openshift:release-4.15 Apr 30, 2026
11 of 12 checks passed

Conversation

sdodson commented Apr 22, 2026

Summary

Test plan

Uh oh!

openshift-ci-robot commented Apr 22, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

coderabbitai Bot commented Apr 22, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Apr 22, 2026

Summary

Test plan

Uh oh!

sdodson commented Apr 22, 2026

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

sdodson commented Apr 22, 2026

Uh oh!

sdodson commented Apr 22, 2026

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

sdodson commented Apr 22, 2026

Uh oh!

sdodson commented Apr 22, 2026

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

devguyio commented Apr 27, 2026

Uh oh!

devguyio commented Apr 29, 2026

Uh oh!

devguyio commented Apr 29, 2026

Uh oh!

devguyio commented Apr 29, 2026

Uh oh!

muraee commented Apr 29, 2026

Uh oh!

muraee commented Apr 29, 2026

Uh oh!

openshift-ci Bot commented Apr 29, 2026

Uh oh!

enxebre commented Apr 29, 2026

Uh oh!

devguyio commented Apr 30, 2026

Uh oh!

openshift-ci-robot commented Apr 30, 2026

Uh oh!

openshift-ci-robot commented Apr 30, 2026

Uh oh!

openshift-ci Bot commented Apr 30, 2026

Uh oh!

devguyio commented Apr 30, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 30, 2026

Uh oh!

enxebre commented Apr 30, 2026

Uh oh!

openshift-ci Bot commented Apr 30, 2026

Uh oh!

openshift-ci Bot commented Apr 30, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 30, 2026

Summary

Test plan

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

openshift-ci-robot commented Apr 22, 2026 •

edited by openshift-ci Bot

Loading