[release-4.22] OCPBUGS-84841: fix(ingress): set FIPS_ENABLED env var on ingress operator by openshift-cherrypick-robot · Pull Request #8388 · openshift/hypershift

openshift-cherrypick-robot · 2026-04-30T19:51:08Z

This is an automated cherry-pick of #8375

/assign csrwng

The ingress operator determines FIPS mode by reading /proc/sys/crypto/fips_enabled on the node where it runs. In hosted clusters the ingress operator runs on the management cluster, which may have a different FIPS state than the hosted cluster. This causes the operator to deploy routers with incorrect cipher configuration when the FIPS states differ. Set FIPS_ENABLED=true on the ingress operator container when the hosted cluster has FIPS enabled, so the operator uses the correct cipher suite regardless of the management cluster's FIPS state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot · 2026-04-30T19:52:18Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-84551 has been cloned as Jira Issue OCPBUGS-84841. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-84841: fix(ingress): set FIPS_ENABLED env var on ingress operator

Details

In response to this:

This is an automated cherry-pick of #8375

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-30T19:52:31Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84841, which is invalid:

expected dependent Jira Issue OCPBUGS-84551 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #8375

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-30T19:56:36Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4943fa62-be4b-4da8-9829-75c644d53bdd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ehearne-redhat · 2026-05-01T13:29:31Z

/test ?

cblecker · 2026-05-01T21:31:50Z

/uncc

sdodson · 2026-05-04T14:12:57Z

/jira refresh

openshift-ci-robot · 2026-05-04T14:13:04Z

@sdodson: This pull request references Jira Issue OCPBUGS-84841, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-84551 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-84551 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

csrwng · 2026-05-05T18:05:25Z

/approve
/lgtm

openshift-ci · 2026-05-05T18:05:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

csrwng · 2026-05-05T18:06:42Z

/retest

Use util.UpsertEnvVar and util.FindContainer instead of podspec.UpsertEnvVar and podspec.FindContainer, since the support/podspec package does not exist in the release-4.22 branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

csrwng · 2026-05-05T18:14:53Z

/lgtm

codecov · 2026-05-05T18:28:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.76%. Comparing base (5fb05fe) to head (a59e691).
⚠️ Report is 11 commits behind head on release-4.22.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22    #8388      +/-   ##
================================================
+ Coverage         34.74%   34.76%   +0.02%     
================================================
  Files               767      767              
  Lines             93310    93314       +4     
================================================
+ Hits              32421    32442      +21     
+ Misses            58214    58196      -18     
- Partials           2675     2676       +1

Files with missing lines	Coverage Δ
...ostedcontrolplane/v2/ingressoperator/deployment.go	`62.06% <100.00%> (+62.06%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

openshift-ci · 2026-05-05T18:32:12Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

csrwng · 2026-05-05T18:54:18Z

/override "Lint / Lint (pull_request)"

openshift-ci · 2026-05-05T18:54:24Z

@csrwng: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

Lint / Lint (pull_request)

Only the following failed contexts/checkruns were expected:

CodeRabbit
Lint
ci/prow/images
ci/prow/security
ci/prow/verify-deps
pull-ci-openshift-hypershift-main-images
pull-ci-openshift-hypershift-main-security
pull-ci-openshift-hypershift-main-verify-deps
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "Lint / Lint (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

csrwng · 2026-05-05T18:54:38Z

/verified by unit test

openshift-ci-robot · 2026-05-05T18:54:50Z

@csrwng: This PR has been marked as verified by unit test.

Details

In response to this:

/verified by unit test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

csrwng · 2026-05-05T18:57:23Z

/override Lint

openshift-ci · 2026-05-05T18:57:51Z

@csrwng: Overrode contexts on behalf of csrwng: Lint

Details

In response to this:

/override Lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-05-05T19:00:26Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-84841
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84841 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #8375

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-05-06T17:39:12Z

Fix included in release 4.22.0-0.nightly-2026-05-06-095717

openshift-cherrypick-robot assigned csrwng Apr 30, 2026

openshift-cherrypick-robot mentioned this pull request Apr 30, 2026

OCPBUGS-84551: fix(ingress): set FIPS_ENABLED env var on ingress operator #8375

Merged

4 tasks

openshift-ci Bot added the do-not-merge/needs-area label Apr 30, 2026

openshift-ci Bot changed the title ~~[release-4.22] OCPBUGS-84551: fix(ingress): set FIPS_ENABLED env var on ingress operator~~ [release-4.22] OCPBUGS-84841: fix(ingress): set FIPS_ENABLED env var on ingress operator Apr 30, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2026

openshift-ci Bot requested review from cblecker and devguyio April 30, 2026 19:53

openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Apr 30, 2026

openshift-ci Bot removed the request for review from cblecker May 1, 2026 21:31

openshift-ci-robot mentioned this pull request May 3, 2026

[release-4.22] OCPBUGS-84841: isFIPSEnabled: Check FIPS_ENABLED env. var. first openshift/cluster-ingress-operator#1429

Merged

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 4, 2026

csrwng added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 5, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 5, 2026

openshift-merge-bot Bot merged commit 41f254c into openshift:release-4.22 May 5, 2026
17 of 18 checks passed

bryan-cox mentioned this pull request May 5, 2026

NO-JIRA: fix(ci): use PR base SHA for api-lint diff in GHA #8430

Merged

2 tasks

Conversation

openshift-cherrypick-robot commented Apr 30, 2026

Uh oh!

openshift-ci-robot commented Apr 30, 2026

Uh oh!

openshift-ci-robot commented Apr 30, 2026

Uh oh!

coderabbitai Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

ehearne-redhat commented May 1, 2026

Uh oh!

cblecker commented May 1, 2026

Uh oh!

sdodson commented May 4, 2026

Uh oh!

openshift-ci-robot commented May 4, 2026

Uh oh!

csrwng commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

csrwng commented May 5, 2026

Uh oh!

csrwng commented May 5, 2026

Uh oh!

codecov Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

csrwng commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

csrwng commented May 5, 2026

Uh oh!

openshift-ci-robot commented May 5, 2026

Uh oh!

csrwng commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 5, 2026

Uh oh!

openshift-merge-robot commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

codecov Bot commented May 5, 2026 •

edited

Loading