[release-4.22] OCPBUGS-85104: fix, cno, skip cloud-network-config-controller check on non-cloud platforms by openshift-cherrypick-robot · Pull Request #8438 · openshift/hypershift

openshift-cherrypick-robot · 2026-05-06T13:26:06Z

This is an automated cherry-pick of #8238

/assign openshift-ci-robot

…tforms The checkOperandsRolloutStatus function unconditionally expected the cloud-network-config-controller deployment when NetworkType is OVNKubernetes. However, this deployment is only created by CNO on cloud platforms (AWS, Azure, GCP, OpenStack) that have cloud APIs for network management. On non-cloud platforms like KubeVirt, Agent, None, IBMCloud, and PowerVS, CNO never creates this deployment, causing the CNO ControlPlaneComponent RolloutComplete condition to be permanently False with reason WaitingForOperands. This blocks controlPlaneVersion from reaching Completed and causes e2e test timeouts. Add a platform check so cloud-network-config-controller is only expected on platforms that actually deploy it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-ci-robot · 2026-05-06T13:26:11Z

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-83410 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.22] OCPBUGS-85104: fix, cno, skip cloud-network-config-controller check on non-cloud platforms

Details

In response to this:

This is an automated cherry-pick of #8238

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-06T13:26:15Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4033e2eb-5474-4979-8489-212fbae91c91

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-05-06T13:26:22Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85104, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #8238

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-05-06T13:40:50Z

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.76%. Comparing base (41f254c) to head (0c24b22).
⚠️ Report is 2 commits behind head on release-4.22.

Files with missing lines	Patch %	Lines
...controllers/hostedcontrolplane/v2/cno/component.go	42.85%	8 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release-4.22    #8438   +/-   ##
=============================================
  Coverage         34.76%   34.76%           
=============================================
  Files               767      767           
  Lines             93314    93325   +11     
=============================================
+ Hits              32442    32448    +6     
- Misses            58196    58201    +5     
  Partials           2676     2676

Files with missing lines	Coverage Δ
...controllers/hostedcontrolplane/v2/cno/component.go	`5.08% <42.85%> (+5.08%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

orenc1 · 2026-05-06T14:09:58Z

/lgtm
needed for openshift/cluster-api-provider-kubevirt#453 to pass

qinqon · 2026-05-06T14:11:50Z

/jira refresh

openshift-ci-robot · 2026-05-06T14:11:58Z

@qinqon: This pull request references Jira Issue OCPBUGS-85104, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-83410 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-83410 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

qinqon · 2026-05-06T14:12:36Z

/approve

qinqon · 2026-05-06T14:14:26Z

/test e2e-kubevirt-aws-ovn-reduced

bryan-cox · 2026-05-06T14:24:13Z

/approve

openshift-ci · 2026-05-06T14:27:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, openshift-cherrypick-robot, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-05-06T17:44:15Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

orenc1 · 2026-05-07T11:25:13Z

/verified by CI

openshift-ci-robot · 2026-05-07T11:25:25Z

@orenc1: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-05-07T11:31:20Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-85104
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-85104 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #8238

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-05-08T16:14:41Z

Fix included in release 4.22.0-0.nightly-2026-05-08-091412

openshift-cherrypick-robot assigned openshift-ci-robot May 6, 2026

openshift-cherrypick-robot mentioned this pull request May 6, 2026

OCPBUGS-83410: fix, cno, skip cloud-network-config-controller check on non-cloud platforms #8238

Merged

4 tasks

openshift-ci Bot changed the title ~~[release-4.22] OCPBUGS-83410: fix, cno, skip cloud-network-config-controller check on non-cloud platforms~~ [release-4.22] OCPBUGS-85104: fix, cno, skip cloud-network-config-controller check on non-cloud platforms May 6, 2026

openshift-ci Bot added the do-not-merge/needs-area label May 6, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2026

openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels May 6, 2026

openshift-ci Bot requested review from bryan-cox and muraee May 6, 2026 13:26

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 6, 2026

openshift-ci Bot assigned orenc1 May 6, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 6, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026

sjenning added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 6, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 7, 2026

openshift-merge-bot Bot merged commit 593f403 into openshift:release-4.22 May 7, 2026
18 checks passed

orenc1 mentioned this pull request May 7, 2026

OCPBUGS-85015: Sync upstream main 2026-04-23 openshift/cluster-api-provider-kubevirt#453

Open

Conversation

openshift-cherrypick-robot commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

coderabbitai Bot commented May 6, 2026

Review skipped

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

codecov Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

orenc1 commented May 6, 2026

Uh oh!

qinqon commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

qinqon commented May 6, 2026

Uh oh!

qinqon commented May 6, 2026

Uh oh!

bryan-cox commented May 6, 2026

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

orenc1 commented May 7, 2026

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

openshift-merge-robot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented May 6, 2026 •

edited

Loading