CNTRLPLANE-2939: Coordinate CRD lifecycle with Cluster CAPI Operator

[muraee]

Summary

• Backport of CNTRLPLANE-2939: Coordinate CRD lifecycle with Cluster CAPI Operator #7996 to release-4.22
• Coordinates CRD lifecycle with the Cluster CAPI Operator during hypershift install by setting unmanaged CRDs in the ClusterAPI singleton config and waiting for the operator to reconcile
• Uses unstructured access for status.observedRevisionGeneration because the field is not present in the vendored operatorv1alpha1.ClusterAPIStatus type on release-4.22

Changes from main

The waitForCAPIOperatorSync function reads the ClusterAPI object as unstructured.Unstructured instead of the typed struct, extracting observedRevisionGeneration, currentRevision, and desiredRevision via unstructured.NestedInt64/NestedString. Tests use interceptor.Funcs to return unstructured objects directly, bypassing the fake client's typed round-trip.

Test plan

• Unit tests pass (go test ./cmd/install/ -v)
• Build succeeds (go build ./cmd/install/)
• E2E: hypershift install on a cluster with Cluster CAPI Operator deployed

[openshift-ci-robot]

@muraee: This pull request references CNTRLPLANE-2939 which is a valid jira issue.

Details

In response to this:

Summary

• Backport of CNTRLPLANE-2939: Coordinate CRD lifecycle with Cluster CAPI Operator #7996 to release-4.22
• Coordinates CRD lifecycle with the Cluster CAPI Operator during hypershift install by setting unmanaged CRDs in the ClusterAPI singleton config and waiting for the operator to reconcile
• Uses unstructured access for status.observedRevisionGeneration because the field is not present in the vendored operatorv1alpha1.ClusterAPIStatus type on release-4.22

Changes from main

The waitForCAPIOperatorSync function reads the ClusterAPI object as unstructured.Unstructured instead of the typed struct, extracting observedRevisionGeneration, currentRevision, and desiredRevision via unstructured.NestedInt64/NestedString. Tests use interceptor.Funcs to return unstructured objects directly, bypassing the fake client's typed round-trip.

Test plan

• Unit tests pass (go test ./cmd/install/ -v)
• Build succeeds (go build ./cmd/install/)
• E2E: hypershift install on a cluster with Cluster CAPI Operator deployed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 44b1c6cb-969c-4afa-98ff-ebbef37e39b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [muraee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 52.50000% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.78%. Comparing base (41f254c) to head (c2b52a7).
⚠️ Report is 8 commits behind head on release-4.22.

Files with missing lines	Patch %	Lines
cmd/install/install.go	52.50%	54 Missing and 3 partials ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22    #8442      +/-   ##
================================================
+ Coverage         34.76%   34.78%   +0.02%     
================================================
  Files               767      767              
  Lines             93314    93434     +120     
================================================
+ Hits              32442    32505      +63     
- Misses            58196    58250      +54     
- Partials           2676     2679       +3     

Files with missing lines	Coverage Δ
cmd/install/install.go	51.51% <52.50%> (+0.11%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[csrwng]

/lgtm

[muraee]

/verified bypass

[openshift-ci-robot]

@muraee: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cblecker]

/uncc

[openshift-ci]

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.