OCPBUGS-86578: bootstrap serving certs at hypershift operator startup by enxebre · Pull Request #8599 · openshift/hypershift

enxebre · 2026-05-27T13:22:25Z

Summary

Cherry-pick of #8545 to release-4.22 (backport of OCPBUGS-84955).

Adds EnsureWebhookCerts bootstrap at operator startup so the webhook server can start even when cert secrets are not pre-provisioned (e.g. hypershift install render without --render-sensitive)
Removes CABundle from CLI-generated webhook and CRD conversion webhook configurations — certs are now managed at runtime by the operator
Marks the serving cert secret volume as optional so the pod can start without it (already present in release-4.22)

Jira: https://issues.redhat.com/browse/OCPBUGS-86578 (clone of https://issues.redhat.com/browse/OCPBUGS-84955)

Test plan

Unit tests for EnsureWebhookCerts (no secrets, existing secrets, empty data, partial secrets)
TestSetupCRDs updated for new setupCRDs signature
All affected packages compile and tests pass

🤖 Generated with Claude Code

openshift-merge-bot · 2026-05-27T13:22:29Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-05-27T13:22:31Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-05-27T13:22:34Z

@enxebre: This pull request references Jira Issue OCPBUGS-84955, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-84955 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #8545 to release-4.22.

Adds EnsureWebhookCerts bootstrap at operator startup so the webhook server can start even when cert secrets are not pre-provisioned (e.g. hypershift install render without --render-sensitive)

Removes CABundle from CLI-generated webhook and CRD conversion webhook configurations — certs are now managed at runtime by the operator

Marks the serving cert secret volume as optional so the pod can start without it (already present in release-4.22)

Test plan

Unit tests for EnsureWebhookCerts (no secrets, existing secrets, empty data, partial secrets)

TestSetupCRDs updated for new setupCRDs signature

All affected packages compile and tests pass

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-27T13:22:36Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8465c4a2-2086-4faf-bccf-9f5c31599761

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-27T13:22:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-05-27T13:28:19Z

@enxebre: This pull request references Jira Issue OCPBUGS-86578, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-86578 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #8545 to release-4.22 (backport of OCPBUGS-84955).

Adds EnsureWebhookCerts bootstrap at operator startup so the webhook server can start even when cert secrets are not pre-provisioned (e.g. hypershift install render without --render-sensitive)

Removes CABundle from CLI-generated webhook and CRD conversion webhook configurations — certs are now managed at runtime by the operator

Marks the serving cert secret volume as optional so the pod can start without it (already present in release-4.22)

Jira: https://issues.redhat.com/browse/OCPBUGS-86578 (clone of https://issues.redhat.com/browse/OCPBUGS-84955)

Test plan

Unit tests for EnsureWebhookCerts (no secrets, existing secrets, empty data, partial secrets)

TestSetupCRDs updated for new setupCRDs signature

All affected packages compile and tests pass

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

enxebre · 2026-05-27T13:29:59Z

/jira refresh

openshift-ci-robot · 2026-05-27T13:30:07Z

@enxebre: This pull request references Jira Issue OCPBUGS-86578, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

enxebre · 2026-05-27T13:33:10Z

/jira refresh

openshift-ci-robot · 2026-05-27T13:33:15Z

@enxebre: This pull request references Jira Issue OCPBUGS-86578, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

enxebre · 2026-05-27T13:34:18Z

/jira refresh

openshift-ci-robot · 2026-05-27T13:34:22Z

@enxebre: This pull request references Jira Issue OCPBUGS-86578, which is invalid:

expected the bug to target only the "4.22.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-05-27T13:37:19Z

Codecov Report

❌ Patch coverage is 59.64912% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.23%. Comparing base (d6c72d1) to head (84c626c).
⚠️ Report is 4 commits behind head on release-4.22.

Files with missing lines	Patch %	Lines
...ontrollers/webhookcerts/webhookcerts_controller.go	72.09%	8 Missing and 4 partials ⚠️
cmd/install/assets/hypershift_operator.go	0.00%	7 Missing ⚠️
hypershift-operator/main.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22    #8599      +/-   ##
================================================
+ Coverage         35.21%   35.23%   +0.01%     
================================================
  Files               767      767              
  Lines             93511    93548      +37     
================================================
+ Hits              32933    32958      +25     
- Misses            57893    57902       +9     
- Partials           2685     2688       +3

Files with missing lines	Coverage Δ
cmd/install/install.go	`51.48% <100.00%> (-0.03%)`	⬇️
hypershift-operator/main.go	`0.00% <0.00%> (ø)`
cmd/install/assets/hypershift_operator.go	`43.59% <0.00%> (-0.03%)`	⬇️
...ontrollers/webhookcerts/webhookcerts_controller.go	`64.55% <72.09%> (+1.44%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

enxebre · 2026-05-27T13:38:48Z

/jira refresh

openshift-ci-robot · 2026-05-27T13:38:56Z

@enxebre: This pull request references Jira Issue OCPBUGS-86578, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-84955 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-84955 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

csrwng · 2026-05-27T13:41:57Z

/lgtm

openshift-merge-bot · 2026-05-27T13:42:52Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

Cherry-pick of openshift#8545 to release-4.22. The webhook server requires TLS certs on disk before it can start listening. Previously, certs were only created via `hypershift install` manifests, meaning the operator would fail to start if the serving cert secret was not yet present like it is the case when running `hypershift install render` without the `--render-sensitive` flag. By adding bootstrap cert generation at startup, the operator is self-sufficient: if the secret exists, the volume mount delivers certs normally; if it is missing or empty, certs are generated, persisted, and written to disk. This also removes the CABundle from CLI-generated webhook configurations and CRD conversion webhooks, since certs are now managed at runtime. Signed-off-by: Alberto Garcia Lamela <agarcial@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci · 2026-05-27T13:47:19Z

New changes are detected. LGTM label has been removed.

openshift-merge-bot · 2026-05-27T13:49:10Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

openshift-merge-robot · 2026-05-27T20:56:12Z

Fix included in release 5.0.0-0.nightly-2026-05-27-134409

cblecker · 2026-05-27T21:13:01Z

/uncc

enxebre · 2026-05-28T11:38:10Z

/retest

cblecker · 2026-05-28T17:25:33Z

/uncc

enxebre · 2026-05-29T16:23:31Z

/verified by e2e

openshift-ci-robot · 2026-05-29T16:23:44Z

@enxebre: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-29T16:43:02Z

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-05-29T16:47:52Z

@enxebre: Jira Issue Verification Checks: Jira Issue OCPBUGS-86578
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-86578 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Cherry-pick of #8545 to release-4.22 (backport of OCPBUGS-84955).

Adds EnsureWebhookCerts bootstrap at operator startup so the webhook server can start even when cert secrets are not pre-provisioned (e.g. hypershift install render without --render-sensitive)

Removes CABundle from CLI-generated webhook and CRD conversion webhook configurations — certs are now managed at runtime by the operator

Marks the serving cert secret volume as optional so the pod can start without it (already present in release-4.22)

Jira: https://issues.redhat.com/browse/OCPBUGS-86578 (clone of https://issues.redhat.com/browse/OCPBUGS-84955)

Test plan

Unit tests for EnsureWebhookCerts (no secrets, existing secrets, empty data, partial secrets)

TestSetupCRDs updated for new setupCRDs signature

All affected packages compile and tests pass

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2026

openshift-ci Bot added the do-not-merge/needs-area label May 27, 2026

openshift-ci Bot added the area/cli Indicates the PR includes changes for CLI label May 27, 2026

openshift-ci Bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels May 27, 2026

enxebre changed the title ~~OCPBUGS-84955: bootstrap serving certs at hypershift operator startup~~ OCPBUGS-86578: bootstrap serving certs at hypershift operator startup May 27, 2026

enxebre force-pushed the cherry-pick-8545-release-4.22 branch from bfa51e5 to fe5f82f Compare May 27, 2026 13:35

enxebre force-pushed the cherry-pick-8545-release-4.22 branch from fe5f82f to 98bbf39 Compare May 27, 2026 13:37

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2026

openshift-ci Bot assigned csrwng May 27, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2026

enxebre force-pushed the cherry-pick-8545-release-4.22 branch from 98bbf39 to 84c626c Compare May 27, 2026 13:46

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2026

enxebre marked this pull request as ready for review May 27, 2026 13:48

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2026

enxebre added the lgtm Indicates that a PR is ready to be merged. label May 27, 2026

openshift-ci Bot requested review from cblecker and muraee May 27, 2026 13:49

enxebre added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 27, 2026

openshift-ci Bot removed the request for review from cblecker May 27, 2026 21:13

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 29, 2026

openshift-merge-bot Bot merged commit 937a38f into openshift:release-4.22 May 29, 2026
25 checks passed

Conversation

enxebre commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

openshift-merge-bot Bot commented May 27, 2026

Uh oh!

openshift-ci Bot commented May 27, 2026

Uh oh!

openshift-ci-robot commented May 27, 2026

Summary

Test plan

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented May 27, 2026

Uh oh!

openshift-ci-robot commented May 27, 2026

Summary

Test plan

Uh oh!

enxebre commented May 27, 2026

Uh oh!

openshift-ci-robot commented May 27, 2026

Uh oh!

enxebre commented May 27, 2026

Uh oh!

openshift-ci-robot commented May 27, 2026

Uh oh!

enxebre commented May 27, 2026

Uh oh!

openshift-ci-robot commented May 27, 2026

Uh oh!

codecov Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

enxebre commented May 27, 2026

Uh oh!

openshift-ci-robot commented May 27, 2026

Uh oh!

csrwng commented May 27, 2026

Uh oh!

openshift-merge-bot Bot commented May 27, 2026

Uh oh!

openshift-ci Bot commented May 27, 2026

Uh oh!

openshift-merge-bot Bot commented May 27, 2026

Uh oh!

openshift-merge-robot commented May 27, 2026

Uh oh!

cblecker commented May 27, 2026

Uh oh!

enxebre commented May 28, 2026

Uh oh!

cblecker commented May 28, 2026

Uh oh!

enxebre commented May 29, 2026

Uh oh!

openshift-ci-robot commented May 29, 2026

Uh oh!

openshift-ci Bot commented May 29, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 29, 2026

Summary

Test plan

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

enxebre commented May 27, 2026 •

edited

Loading

coderabbitai Bot commented May 27, 2026 •

edited

Loading

codecov Bot commented May 27, 2026 •

edited

Loading