NO-JIRA: chore(ci): enforce v2 e2e AGENTS.md standards via CodeRabbit

[cblecker]

Summary

• Fix knowledge_base.code_guidelines.filePatterns glob from AGENTS.md (root-only match) to **/AGENTS.md so CodeRabbit actually ingests test/e2e/v2/AGENTS.md as a knowledge source
• Add a path_instructions entry scoped to test/e2e/v2/**/*.go that instructs CodeRabbit to actively enforce the standards from test/e2e/v2/AGENTS.md on every PR touching those files

test/e2e/v2/AGENTS.md remains the single source of truth — no rules are duplicated into the CodeRabbit config.

Test plan

• Merge and open a follow-up PR touching a file under test/e2e/v2/tests/ — confirm CodeRabbit flags violations of the AGENTS.md standards (e.g. use of context.Background(), "guest cluster" terminology, missing vacuous-pass guards)
• Alternatively, trigger @coderabbitai review on an existing PR touching v2 e2e files to validate the new instructions take effect

Summary by CodeRabbit

• Chores
  • Updated code review configuration to enforce testing standards more strictly across automated test files and expanded guideline file matching to improve code quality consistency.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@cblecker: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Fix knowledge_base.code_guidelines.filePatterns glob from AGENTS.md (root-only match) to **/AGENTS.md so CodeRabbit actually ingests test/e2e/v2/AGENTS.md as a knowledge source
• Add a path_instructions entry scoped to test/e2e/v2/**/*.go that instructs CodeRabbit to actively enforce the standards from test/e2e/v2/AGENTS.md on every PR touching those files

test/e2e/v2/AGENTS.md remains the single source of truth — no rules are duplicated into the CodeRabbit config.

Test plan

• Merge and open a follow-up PR touching a file under test/e2e/v2/tests/ — confirm CodeRabbit flags violations of the AGENTS.md standards (e.g. use of context.Background(), "guest cluster" terminology, missing vacuous-pass guards)
• Alternatively, trigger @coderabbitai review on an existing PR touching v2 e2e files to validate the new instructions take effect

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e3dd8af3-46cd-4969-b245-7e185058b160

📥 Commits

Reviewing files that changed from the base of the PR and between af95f84 and c67f2c9.

📒 Files selected for processing (1)

• .coderabbit.yaml

---

📝 Walkthrough

Walkthrough

This pull request updates the CodeRabbit review configuration file to strengthen enforcement of agent guidelines. It adds a path-specific instruction rule that requires strict adherence to standards defined in test/e2e/v2/AGENTS.md when reviewing changes to Go files in test/e2e/v2/**/*.go. Additionally, it broadens the knowledge base file pattern matching from AGENTS.md to **/AGENTS.md, allowing the system to recognize agent guideline files at any directory level rather than only at the root level.

Suggested reviewers

• sjenning
• bryan-cox

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating the CodeRabbit configuration to enforce AGENTS.md standards for v2 e2e tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies .coderabbit.yaml configuration file; no Ginkgo test code is added or changed, so the stable test names check does not apply.
Test Structure And Quality	✅ Passed	PR only modifies .coderabbit.yaml configuration to enforce test standards via CodeRabbit; doesn't review or change actual test code, so test quality check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only .coderabbit.yaml (CI configuration) to enforce test standards; does not introduce deployment manifests, operator code, controllers, or scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only .coderabbit.yaml configuration; no new Ginkgo e2e tests are added, so IPv6/disconnected network check does not apply.
No-Weak-Crypto	✅ Passed	PR modifies .coderabbit.yaml configuration file only; no weak cryptography (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) introduced.
Container-Privileges	✅ Passed	PR modifies only .coderabbit.yaml config file; contains no container/K8s manifests or privileged security settings.
No-Sensitive-Data-In-Logs	✅ Passed	Configuration file change with no logging statements or sensitive data. File only contains CodeRabbit review settings without exposing passwords, tokens, or PII.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

This is an automated notification from the OpenShift CI bot. The PR title uses the NO-JIRA: prefix, which is the accepted format per this project's guidelines when no Jira issue exists. Since this PR is a pure CI/CodeRabbit configuration change with no code or API modifications, the NO-JIRA: designation is appropriate here.

---

🧠 Learnings used

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .cursor/rules/code-review.mdc:0-0
Timestamp: 2026-05-28T13:02:29.570Z
Learning: Use the rules described at https://hypershift.pages.dev/contribute/#prior-to-submitting-a-pull-request to analyze code changes

---

Learnt from: PoornimaSingour
Repo: openshift/hypershift PR: 8544
File: docs/content/how-to/automated-machine-management/nodepool-lifecycle.md:89-99
Timestamp: 2026-05-20T10:07:05.899Z
Learning: In `docs/content/how-to/automated-machine-management/nodepool-lifecycle.md` (openshift/hypershift repo), all fenced code blocks intentionally use plain triple-backtick fences without a language identifier. Do not flag missing language identifiers (MD040) on code blocks in this file unless all blocks are being updated together for consistency.

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .claude/agents/data-plane-sme.md:0-0
Timestamp: 2026-05-28T13:01:46.305Z
Learning: Applies to **/*.go : Use golang common kubernetes patterns and best practices in code changes

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: vendor/github.com/aws/smithy-go/CONTRIBUTING.md:0-0
Timestamp: 2026-05-28T13:10:09.819Z
Learning: Focus pull requests on specific changes and avoid reformatting all code in a single PR

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .claude/agents/hcp-architect-sme.md:0-0
Timestamp: 2026-05-28T13:02:02.999Z
Learning: Applies to **/*.go : Implement code changes using Go common kubernetes patterns and best practices

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: hack/tools/vendor/go.opentelemetry.io/otel/CONTRIBUTING.md:0-0
Timestamp: 2026-05-28T13:08:28.218Z
Learning: Applies to hack/tools/vendor/go.opentelemetry.io/otel/**/CHANGELOG.md : Update `CHANGELOG.md` and add the pull request ID to the entry when submitting a PR

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-05-28T13:01:07.534Z
Learning: Prefix PR titles with a Jira ticket number (e.g., `OCPBUGS-12345:`) and use `NO-JIRA:` only sparingly when no Jira issue exists

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: test/e2e/v2/CLAUDE.md:0-0
Timestamp: 2026-05-28T13:05:11.479Z
Learning: Applies to test/e2e/v2/**/AGENTS.md : Document agent implementation in AGENTS.md file

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-28T13:04:55.173Z
Learning: Read the AGENTS.md file for specific guidelines

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .claude/agents/hcp-architect-sme.md:0-0
Timestamp: 2026-05-28T13:02:02.999Z
Learning: Include e2e tests when Go code changes impact consumer behavior

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .claude/agents/api-sme.md:0-0
Timestamp: 2026-05-28T13:01:16.466Z
Learning: Applies to api/**/*.go : Follow api/AGENTS.md guidelines for API design, versioning, and error reporting decisions

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: hack/tools/vendor/github.com/mikefarah/yq/v4/CONTRIBUTING.md:0-0
Timestamp: 2026-06-03T09:43:52.237Z
Learning: Applies to hack/tools/vendor/github.com/mikefarah/yq/v4/**/*_test.go : Write unit tests for code changes - changes will not be accepted without corresponding unit tests. Update operator documentation by modifying *_test.go files, as these automatically update matching *.md files

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .claude/agents/api-sme.md:0-0
Timestamp: 2026-05-28T13:01:16.466Z
Learning: Applies to api/**/*.go : Apply golang common kubernetes patterns and best practices for code changes in API implementations

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .claude/agents/api-sme.md:0-0
Timestamp: 2026-05-28T13:01:16.466Z
Learning: Applies to api/**/*.go : Review clusterAPI changes (e.g., MachineDeployments) for API design alignment with Kubernetes conventions

---

Learnt from: CR
Repo: openshift/hypershift PR: 0
File: .claude/agents/api-sme.md:0-0
Timestamp: 2026-05-28T13:01:16.466Z
Learning: Applies to api/**/*_test.go : Unit test any API code changes and additions, and include e2e tests when changes impact consumer behavior

[bryan-cox]

/lgtm

[bryan-cox]

/area ci-tooling

[bryan-cox]

/verified later @cblecker

[openshift-ci-robot]

@bryan-cox: This PR has been marked to be verified later by @cblecker.

Details

In response to this:

/verified later @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox,cblecker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.39%. Comparing base (7461f85) to head (c67f2c9).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8660      +/-   ##
==========================================
+ Coverage   41.27%   41.39%   +0.12%     
==========================================
  Files         755      756       +1     
  Lines       93446    93613     +167     
==========================================
+ Hits        38566    38750     +184     
+ Misses      52148    52134      -14     
+ Partials     2732     2729       -3     

see 2 files with indirect coverage changes

Flag	Coverage Δ
cmd-support	34.86% <ø> (ø)
cpo-hostedcontrolplane	43.50% <ø> (ø)
cpo-other	42.79% <ø> (ø)
hypershift-operator	51.41% <ø> (+0.40%)	⬆️
other	31.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.