OCPBUGS-77351: fix: add terminationMessagePolicy to runtime extractor containers by mandre · Pull Request #1286 · openshift/insights-operator

mandre · 2026-05-06T14:59:55Z

The exporter and extractor containers in the insights-runtime-extractor DaemonSet were missing terminationMessagePolicy=FallbackToLogsOnError, causing CI test failures.

Summary by CodeRabbit

Chores
- Improved infrastructure stability and resource management by configuring container resource requests (CPU/memory) and implementing proper termination handling policies for the runtime extractor deployment.

… containers The exporter and extractor containers in the insights-runtime-extractor DaemonSet were missing terminationMessagePolicy=FallbackToLogsOnError, causing CI test failures.

openshift-ci-robot · 2026-05-06T15:00:03Z

@mandre: This pull request references Jira Issue OCPBUGS-77351, which is invalid:

expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The exporter and extractor containers in the insights-runtime-extractor DaemonSet were missing terminationMessagePolicy=FallbackToLogsOnError, causing CI test failures.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-06T15:00:11Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 56125f8e-0e4a-417e-8b50-ab144c2fdf89

📥 Commits

Reviewing files that changed from the base of the PR and between 7af0298 and 38069f9.

📒 Files selected for processing (1)

manifests/10-insights-runtime-extractor.yaml

📝 Walkthrough

Walkthrough

The pull request updates the insights-runtime-extractor DaemonSet manifest to include termination message policies and resource requests for both the exporter and extractor containers, specifying CPU and memory constraints.

Changes

Container Configuration & Resource Requests

Layer / File(s)	Summary
Termination Message Policy `manifests/10-insights-runtime-extractor.yaml` (lines 72, 90)	Added `terminationMessagePolicy: FallbackToLogsOnError` to both exporter and extractor containers to capture termination messages in container logs.
Resource Requests `manifests/10-insights-runtime-extractor.yaml` (lines 83–87, 103–106)	Added resource requests to both containers: `cpu: 10m` and `memory: 200Mi` for scheduler and resource management.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is minimal and does not follow the repository's template structure. Required sections like Categories, Sample Archive, Documentation, Unit Tests, and other fields are missing or unfilled.	Expand the description to follow the template by filling in relevant sections, particularly specifying if this is a Bugfix, whether sample/documentation changes are needed, and providing the Jira reference URL.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding terminationMessagePolicy to runtime extractor containers, directly addressing the core fix in the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR only modifies manifest files and contains no Ginkgo tests. The repository uses standard Go testing, not Ginkgo.
Test Structure And Quality	✅ Passed	PR modifies only a Kubernetes manifest file to add terminationMessagePolicy and resource requests. No test code changes present. Check for Ginkgo test quality is not applicable.
Microshift Test Compatibility	✅ Passed	PR only modifies a manifest file (adds terminationMessagePolicy and resources). No new Ginkgo e2e tests are added, so check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only modifies the insights-runtime-extractor.yaml DaemonSet manifest to add terminationMessagePolicy. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies a DaemonSet with kubernetes.io/os nodeSelector (not control-plane-specific). No anti-affinity, topology spread, or problematic scheduling constraints introduced. Topology-compatible.
Ote Binary Stdout Contract	✅ Passed	PR only modifies Kubernetes manifest file (YAML) with no code changes. OTE Binary Stdout Contract check is not applicable to manifest-only changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only modifies a Kubernetes manifest file, not Go test code. Custom check applies only to new Ginkgo e2e tests, which are not present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jmesnil · 2026-05-06T15:12:30Z

/jira refresh

openshift-ci-robot · 2026-05-06T15:12:35Z

@jmesnil: This pull request references Jira Issue OCPBUGS-77351, which is invalid:

expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jmesnil

/lgtm

jmesnil · 2026-05-06T15:13:17Z

/jira refresh

openshift-ci-robot · 2026-05-06T15:13:25Z

@jmesnil: This pull request references Jira Issue OCPBUGS-77351, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @BaiyangZhou

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-06T15:13:29Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: BaiyangZhou.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@jmesnil: This pull request references Jira Issue OCPBUGS-77351, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (5.0.0) matches configured target version for branch (5.0.0)

bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @BaiyangZhou

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mandre · 2026-05-07T13:37:32Z

/retest-required

opokornyy · 2026-05-11T13:05:19Z

/approve

opokornyy · 2026-05-11T13:07:48Z

/verified later @opokornyy

openshift-ci-robot · 2026-05-11T13:08:02Z

@opokornyy: This PR has been marked to be verified later by @opokornyy.

Details

In response to this:

/verified later @opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-11T13:09:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmesnil, mandre, opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [opokornyy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-05-11T17:40:44Z

/retest-required

Remaining retests: 0 against base HEAD 5bb6dd4 and 2 for PR HEAD 38069f9 in total

openshift-ci · 2026-05-11T21:25:16Z

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-05-11T21:29:54Z

@mandre: Jira Issue OCPBUGS-77351: All pull requests linked via external trackers have merged:

openshift/insights-operator#1286

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-77351 has been moved to the MODIFIED state.

Details

In response to this:

The exporter and extractor containers in the insights-runtime-extractor DaemonSet were missing terminationMessagePolicy=FallbackToLogsOnError, causing CI test failures.

Summary by CodeRabbit

Chores

Improved infrastructure stability and resource management by configuring container resource requests (CPU/memory) and implementing proper termination handling policies for the runtime extractor deployment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-05-12T08:18:19Z

Fix included in release 5.0.0-0.nightly-2026-05-12-025124

OCPBUGS-77351: fix: add terminationMessagePolicy to runtime extractor…

38069f9

… containers The exporter and extractor containers in the insights-runtime-extractor DaemonSet were missing terminationMessagePolicy=FallbackToLogsOnError, causing CI test failures.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2026

openshift-ci Bot requested review from katushiik11 and opokornyy May 6, 2026 15:03

jmesnil approved these changes May 6, 2026

View reviewed changes

openshift-ci Bot assigned jmesnil May 6, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels May 11, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2026

openshift-merge-bot Bot merged commit 50b45c2 into openshift:master May 11, 2026
12 checks passed

Conversation

mandre commented May 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

coderabbitai Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

jmesnil commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

jmesnil left a comment

Choose a reason for hiding this comment

Uh oh!

jmesnil commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

mandre commented May 7, 2026

Uh oh!

opokornyy commented May 11, 2026

Uh oh!

opokornyy commented May 11, 2026

Uh oh!

openshift-ci-robot commented May 11, 2026

Uh oh!

openshift-ci Bot commented May 11, 2026

Uh oh!

openshift-merge-bot Bot commented May 11, 2026

Uh oh!

openshift-ci Bot commented May 11, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 11, 2026

Summary by CodeRabbit

Uh oh!

openshift-merge-robot commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mandre commented May 6, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 6, 2026 •

edited

Loading