aws/permissions: Add s3:GetBucketObjectLockConfiguration to pre-flight checks#1491
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Mar 29, 2019
Conversation
…nfiguration And alphabetize this section. The new permission avoids [1]: error getting S3 Bucket Object Lock configuration: AccessDenied which came in with our Terraform bump from d1c17b7 (terraform/exec/plugins/vendor: Bump terraform-provider-aws to v2.2.0, 2019-03-19, openshift#1442). [1]: hashicorp/terraform-provider-aws#7550
Member
Author
|
From @csrwng:
so I don't think we're missing anything else. It would be nice to have CI coverage to ensure that our set of required permissions was sufficient (even if it would be hard to ensure it was minimal), but I'm punting all of that to follow-up work. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
/retest |
Member
Author
/retest |
Member
Author
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And alphabetize this section. The new permission avoids:
which came in with our Terraform bump from d1c17b7 (#1442).