Bug 1878758: openstack UPI: Allow for no FIP or router by pierreprinetti · Pull Request #4219 · openshift/installer

pierreprinetti · 2020-09-25T16:43:54Z

If the external network is not provided, the router will not be created
and external connectivity will be a respopnsibility of the operator.

Floating IPs will be set if available, on an individual basis. The
external network is a requirement for FIPs; if not provided, the
playbooks will error.

The bootstrap FIP is now required to be created manually like the other
FIPs.

This is a follow-up to #3755.

/cc luis5tb adduarte iamemilio mandre

pierreprinetti · 2020-09-25T16:45:38Z

The e2e-openstack-upi job is expected to fail until I adapt the job to create a bootstrap FIP manually.

May I get a review (/approve) before I start doing that?

luis5tb · 2020-09-28T06:54:18Z

Looks good to me, just a couple of questions:

Is bootstrap FIP also a requirement now for IPI?
Should we also document the option when you don't want to connect to an external network (like FIPless + disconnected)

pierreprinetti · 2020-09-28T14:38:28Z

Is bootstrap FIP also a requirement now for IPI?

It is not. In this patch, IPI and UPI diverge a bit in that respect.

Should we also document the option when you don't want to connect to an external network (like FIPless + disconnected)

This new PR aims at narrowing the scope of the change as much as possible, and at avoiding any magic. I believe that working towards supporting the absence of an external network is the natural next step. However, I'd treat it as a separate change. WDYT?

mandre

It's not clear exactly what problem we're trying to solve here.

Letting the user specify the bootstrap FIP makes some sense to me in a UPI scenario, but why forcing an external network? It's a regression from the previous implementation

openshift-ci-robot · 2020-09-29T12:54:13Z

@pierreprinetti: This pull request references Bugzilla bug 1878758, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1878758: openstack UPI: Allow for no FIP or router

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2020-09-29T12:54:15Z

/label platform/openstack

pierreprinetti · 2020-09-29T12:54:56Z

Made the external network optional again. Required for FIPs. FIPs can be passed on an individual basis.

docs/user/openstack/install_upi.md

upi/openstack/bootstrap.yaml

mandre · 2020-09-30T06:58:34Z

/retest

pierreprinetti · 2020-09-30T07:24:11Z

/cc @MaysaMacedo

MaysaMacedo

Looks good, just a question and suggestion:

docs/user/openstack/install_upi.md

upi/openstack/inventory.yaml

pierreprinetti · 2020-09-30T11:29:29Z

e2e-openstack-upi requires openshift/release#12322

mandre · 2020-10-01T12:43:57Z

/retest

upi/openstack/bootstrap.yaml

Fedosin

one small typo :)

docs/user/openstack/install_upi.md

pierreprinetti · 2020-10-02T05:56:23Z

openshift/release#12385

mandre · 2020-10-02T06:42:33Z

/test e2e-openstack-upi

If the external network is not provided, the router will not be created and external connectivity will be a respopnsibility of the operator. Floating IPs will be set if available, on an individual basis. The external network is a requirement for FIPs; if not provided, the playbooks will error. The bootstrap FIP is now required to be created manually like the other FIPs.

mandre · 2020-10-02T11:25:59Z

/lgtm
/approve

openshift-ci-robot · 2020-10-02T11:26:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~docs/user/openstack/OWNERS~~ [mandre]
~~upi/openstack/OWNERS~~ [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-10-02T11:30:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-02T12:36:51Z

@pierreprinetti: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	`7df6205`	link	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-10-02T12:38:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-02T13:21:14Z

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1878758 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1878758: openstack UPI: Allow for no FIP or router

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from adduarte, iamemilio, luis5tb and mandre September 25, 2020 16:43

mandre reviewed Sep 29, 2020

View reviewed changes

pierreprinetti force-pushed the os_upi_fipless_router branch from d78fe40 to 3a85f15 Compare September 29, 2020 12:53

pierreprinetti changed the title ~~openstack UPI: Create a router when FIPless~~ openstack UPI: Allow for no FIP or router Sep 29, 2020

pierreprinetti changed the title ~~openstack UPI: Allow for no FIP or router~~ Bug 1878758: openstack UPI: Allow for no FIP or router Sep 29, 2020

openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot added the platform/openstack label Sep 29, 2020

mandre reviewed Sep 29, 2020

View reviewed changes

docs/user/openstack/install_upi.md Outdated Show resolved Hide resolved

docs/user/openstack/install_upi.md Outdated Show resolved Hide resolved

upi/openstack/bootstrap.yaml Outdated Show resolved Hide resolved

pierreprinetti force-pushed the os_upi_fipless_router branch from 3a85f15 to 57a8ef3 Compare September 29, 2020 14:15

openshift-ci-robot requested a review from MaysaMacedo September 30, 2020 07:24

MaysaMacedo reviewed Sep 30, 2020

View reviewed changes

docs/user/openstack/install_upi.md Outdated Show resolved Hide resolved

upi/openstack/inventory.yaml Outdated Show resolved Hide resolved

pierreprinetti force-pushed the os_upi_fipless_router branch from 57a8ef3 to 45e8ac2 Compare September 30, 2020 08:48

pierreprinetti mentioned this pull request Sep 30, 2020

e2e-openstack-upi: Create the bootstrap FIP openshift/release#12322

Merged

pierreprinetti force-pushed the os_upi_fipless_router branch from 45e8ac2 to 9b9ee29 Compare October 1, 2020 13:47

mandre reviewed Oct 1, 2020

View reviewed changes

upi/openstack/bootstrap.yaml Outdated Show resolved Hide resolved

Fedosin suggested changes Oct 1, 2020

View reviewed changes

docs/user/openstack/install_upi.md Outdated Show resolved Hide resolved

pierreprinetti force-pushed the os_upi_fipless_router branch 2 times, most recently from 99ccd7c to ee3f486 Compare October 1, 2020 18:58

pierreprinetti force-pushed the os_upi_fipless_router branch from ee3f486 to 7df6205 Compare October 2, 2020 08:38

openshift-ci-robot assigned mandre Oct 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020

openshift-merge-robot merged commit e1fe5b5 into openshift:master Oct 2, 2020

pierreprinetti deleted the os_upi_fipless_router branch October 2, 2020 13:53

mandre mentioned this pull request Oct 12, 2020

OSP IPI and UPI without FIPs - OSDOCS 1288 and 1275 openshift/openshift-docs#25216

Merged

Conversation

pierreprinetti commented Sep 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierreprinetti commented Sep 25, 2020

Uh oh!

luis5tb commented Sep 28, 2020

Uh oh!

pierreprinetti commented Sep 28, 2020

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

pierreprinetti commented Sep 29, 2020

Uh oh!

pierreprinetti commented Sep 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mandre commented Sep 30, 2020

Uh oh!

pierreprinetti commented Sep 30, 2020

Uh oh!

MaysaMacedo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pierreprinetti commented Sep 30, 2020

Uh oh!

mandre commented Oct 1, 2020

Uh oh!

Uh oh!

Fedosin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pierreprinetti commented Oct 2, 2020

Uh oh!

mandre commented Oct 2, 2020

Uh oh!

mandre commented Oct 2, 2020

Uh oh!

openshift-ci-robot commented Oct 2, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-ci-robot commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-ci-robot commented Oct 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pierreprinetti commented Sep 25, 2020 •

edited

Loading

openshift-ci-robot commented Oct 2, 2020 •

edited

Loading