baremetal: correct the cacheImageURL when we don't have a provisioningIP

[asalkeld]

/cc @zaneb

[zaneb]

Look legit (note this will only be useful once a future change has merged to cluster-baremetal-operator).
/approve

[hardys]

/label platform/baremetal

[hardys]

Looks good - should hold this until the CBO change is merged?

Also perhaps we should add a comment or link to explain why cacheImagePort is different?

/approve
/cc @stbenjam

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/machines/baremetal/OWNERS [hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

This code isn't really reachable without tricks until we remove the validation on ClusterProvisioningIP. It can be tested manually if you're editing the provisioning CR before running create cluster, so there's some value in getting it in now.

Let's test disabled networking though:

/test e2e-metal-ipi-virtualmedia

[openshift-ci-robot]

@stbenjam: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

• /test e2e-aws
• /test e2e-aws-disruptive
• /test e2e-aws-fips
• /test e2e-aws-proxy
• /test e2e-aws-rhel8
• /test e2e-aws-shared-vpc
• /test e2e-aws-upgrade
• /test e2e-aws-upi
• /test e2e-aws-workers-rhel7
• /test e2e-azure
• /test e2e-azure-shared-vpc
• /test e2e-azure-upi
• /test e2e-crc
• /test e2e-gcp
• /test e2e-gcp-shared-vpc
• /test e2e-gcp-upgrade
• /test e2e-gcp-upi
• /test e2e-gcp-upi-xpn
• /test e2e-libvirt
• /test e2e-metal
• /test e2e-metal-assisted
• /test e2e-metal-ipi
• /test e2e-openstack
• /test e2e-openstack-ipi
• /test e2e-openstack-parallel
• /test e2e-openstack-upi
• /test e2e-ovirt
• /test e2e-vsphere
• /test e2e-vsphere-upi
• /test gofmt
• /test golint
• /test govet
• /test images
• /test shellcheck
• /test tf-fmt
• /test tf-lint
• /test unit
• /test verify-codegen
• /test verify-vendor
• /test yaml-lint

Use /test all to run the following jobs:

• pull-ci-openshift-installer-master-e2e-aws
• pull-ci-openshift-installer-master-e2e-aws-fips
• pull-ci-openshift-installer-master-e2e-aws-upgrade
• pull-ci-openshift-installer-master-e2e-aws-workers-rhel7
• pull-ci-openshift-installer-master-e2e-crc
• pull-ci-openshift-installer-master-e2e-libvirt
• pull-ci-openshift-installer-master-e2e-metal-ipi
• pull-ci-openshift-installer-master-e2e-openstack
• pull-ci-openshift-installer-master-e2e-ovirt
• pull-ci-openshift-installer-master-gofmt
• pull-ci-openshift-installer-master-golint
• pull-ci-openshift-installer-master-govet
• pull-ci-openshift-installer-master-images
• pull-ci-openshift-installer-master-shellcheck
• pull-ci-openshift-installer-master-tf-fmt
• pull-ci-openshift-installer-master-tf-lint
• pull-ci-openshift-installer-master-unit
• pull-ci-openshift-installer-master-verify-codegen
• pull-ci-openshift-installer-master-verify-vendor
• pull-ci-openshift-installer-master-yaml-lint

Details

In response to this:

This code isn't really reachable without tricks until we remove the validation on ClusterProvisioningIP. It can be tested manually if you're editing the provisioning CR before running create cluster, so there's some value in getting it in now.

Let's test disabled networking though:

/test e2e-metal-ipi-virtualmedia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

openshift/release#13852 adds virtualmedia to this repo

[stbenjam]

/test e2e-metal-ipi-virtualmedia

[stbenjam]

/test e2e-metal-ipi-virtualmedia

[stbenjam]

/test e2e-metal-ipi-virtualmedia

[asalkeld]

/retest

[stbenjam]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-merge-robot]

@asalkeld: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-crc	be5aa7c	link	/test e2e-crc
ci/prow/e2e-aws-workers-rhel7	be5aa7c	link	/test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.