Skip to content

Openstack: describes how to enable qemu agent for UPI.#4441

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:enable_qemu_agent_for_upi
Dec 10, 2020
Merged

Openstack: describes how to enable qemu agent for UPI.#4441
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:enable_qemu_agent_for_upi

Conversation

@adduarte
Copy link

@adduarte adduarte commented Dec 2, 2020 •
edited by openshift-ci-robot
Loading

implements OSASINFRA-2191

@adduarte
Copy link
Author

adduarte commented Dec 2, 2020

/label platform/openstack

mandre
mandre reviewed Dec 4, 2020
View reviewed changes
@adduarte adduarte force-pushed the enable_qemu_agent_for_upi branch from 3e65c35 to 768568a Compare December 10, 2020 07:03
@adduarte adduarte requested a review from mandre December 10, 2020 07:04
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 10, 2020

@adduarte: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 3e65c35de215c961415acdecba7816187dc12cf7 link /test e2e-metal-ipi
ci/prow/e2e-aws-workers-rhel7 3e65c35de215c961415acdecba7816187dc12cf7 link /test e2e-aws-workers-rhel7
ci/prow/e2e-metal-ipi-ovn-ipv6 768568a58e50f7e9155e02e93263c2e839c659ad link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc 768568a58e50f7e9155e02e93263c2e839c659ad link /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre
mandre reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little typo, looks good otherwise.

docs/user/openstack/install_upi.md Outdated
Copy link
Member

@mandre mandre Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To enable this feature, you must add the `hw_qemu_guest_agent=yes` poperty to the image:
To enable this feature, you must add the `hw_qemu_guest_agent=yes` property to the image:

@mandre mandre force-pushed the enable_qemu_agent_for_upi branch from 768568a to fc126df Compare December 10, 2020 08:34
@mandre mandre force-pushed the enable_qemu_agent_for_upi branch from fc126df to 12a5f75 Compare December 10, 2020 08:35
mandre
mandre reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6cbe488 into openshift:master Dec 10, 2020
@pierreprinetti pierreprinetti deleted the enable_qemu_agent_for_upi branch December 10, 2020 13:22
@iamemilio
Copy link

iamemilio commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

Implements: OSASINFRA-2192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adduarte @openshift-merge-robot @openshift-ci-robot @iamemilio @mandre