CORS-2628: Allow users to set ManagedBy tag to resource group#7205
CORS-2628: Allow users to set ManagedBy tag to resource group#7205openshift-merge-robot merged 5 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rna-afk: This pull request references CORS-2628 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bennerv
left a comment
bennerv
left a comment
There was a problem hiding this comment.
@rna-afk I think there's some confusion here.
The managedBy field isn't a tag, it's an actual field on the resource group. It looks like terraform doesn't have native support for this field yet, which was realized late last week.
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/resource_group.
The below shows that there's a difference.
$ az group show -n aro-dsfx17my
{
"id": "/subscriptions/<sub-id>/resourceGroups/aro-dsfx17my",
"location": "eastus",
"managedBy": "/subscriptions/<sub-id>/resourceGroups/shared-cluster/providers/Microsoft.RedHatOpenShift/openShiftClusters/shared-cluster",
"name": "aro-dsfx17my",
"properties": {
"provisioningState": "Succeeded"
},
"tags": {
"abd": "def",
"createdAt": "2023-04-12T20:54:10.7804839Z",
"hello": "world",
"something": "something",
"test": "test"
},
"type": "Microsoft.Resources/resourceGroups"
}
rna-afk
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Updating azurerm provider version to latest (v.3.64) to bring in the changes made to the azurerm_resource_group to add new field `managed_by`.
rna-afk
force-pushed
the
azure_managed_by_tag
branch
from
cb73213 to
c8a2837
Compare
rna-afk
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Adding a pipe from the install config to terraform for enabling users to set the managedBy tag in the resource group. Defaulting to "openshift" if the field is not set.
vendoring modules after change of version for azurerm provider
Fixing the modules as per verify-vendor test
rna-afk
force-pushed
the
azure_managed_by_tag
branch
from
7db8dad to
290efef
Compare
|
/retest-required |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold Revision 36bf1aa was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/override ci/prow/okd-scos-images |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/okd-scos-images |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/skip |
OCPBUGS-17073: Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag"
CORS-2628: Allow users to set ManagedBy tag to resource group
OCPBUGS-17073: Revert "Merge pull request openshift#7205 from rna-afk/azure_managed_by_tag"
6 participants
Adding a pipe from the install config to terraform for enabling users to set the managedBy tag in the resource group. Defaulting to "openshift" if the field is not set.