OCPBUGS-17073: Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag" by rna-afk · Pull Request #7412 · openshift/installer

rna-afk · 2023-08-09T16:33:39Z

This reverts commit 87fbf26, reversing changes made to 26a0d5c.

…by_tag" This reverts commit 87fbf26, reversing changes made to 26a0d5c.

r4f4

/lgtm

r4f4 · 2023-08-09T21:02:38Z

/lgtm cancel
We need tf-azure provider >= 3.43.0 for the confidential VM feature

terraform/providers/azurerm/go.mod

r4f4

The terraform chagnes need to be vendored in.

r4f4 · 2023-08-10T18:18:37Z

/refresh

rna-afk · 2023-08-14T16:02:20Z

/retest

patrickdillon · 2023-08-14T17:30:29Z

/approve

patrickdillon · 2023-08-15T18:57:01Z

/lgtm

patrickdillon · 2023-08-15T18:58:46Z

/jira refresh

openshift-ci-robot · 2023-08-15T19:29:09Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-17073, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-08-15T19:31:58Z

@rna-afk: This pull request references Jira Issue OCPBUGS-17073, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This reverts commit 87fbf26, reversing changes made to 26a0d5c.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rna-afk · 2023-08-15T21:22:23Z

/jira refresh

openshift-ci-robot · 2023-08-15T21:22:35Z

@rna-afk: This pull request references Jira Issue OCPBUGS-17073, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MayXuQQ · 2023-08-16T05:44:47Z

MAG cluster install succeed with pre-merge build

openshift-ci · 2023-08-16T05:46:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MayXuQQ, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rna-afk · 2023-08-22T12:38:45Z

/retest

openshift-ci-robot · 2023-08-22T14:01:37Z

/retest-required

Remaining retests: 0 against base HEAD e20821e and 2 for PR HEAD a34b5355152bc36bc58d205439e29e98b8a7e5d9 in total

openshift-ci-robot · 2023-08-22T23:25:11Z

/retest-required

Remaining retests: 0 against base HEAD 02357cc and 1 for PR HEAD a34b5355152bc36bc58d205439e29e98b8a7e5d9 in total

openshift-ci-robot · 2023-08-23T14:18:42Z

/retest-required

Remaining retests: 0 against base HEAD 87f73b5 and 0 for PR HEAD a34b5355152bc36bc58d205439e29e98b8a7e5d9 in total

r4f4 · 2023-08-23T14:47:12Z

/test tf-fmt

openshift-ci-robot · 2023-08-23T15:18:38Z

/hold

Revision a34b5355152bc36bc58d205439e29e98b8a7e5d9 was retested 3 times: holding

r4f4 · 2023-08-23T21:52:09Z

@rna-afk do you plan on squashing d957492 into a34b535?

Setting to v3.43.0 to support confidential VMs.

rna-afk · 2023-08-23T22:02:20Z

@r4f4 squashed

r4f4 · 2023-08-23T22:02:51Z

/hold cancel
/lgtm

openshift-ci-robot · 2023-08-24T01:35:47Z

/retest-required

Remaining retests: 0 against base HEAD af5e9d1 and 2 for PR HEAD fa32bf0 in total

openshift-ci · 2023-08-24T04:01:13Z

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-xpn	85de53883cc8f00e6a4c72d6895f9960d1e12e5b	link	false	`/test e2e-gcp-ovn-xpn`
ci/prow/e2e-gcp-ovn	85de53883cc8f00e6a4c72d6895f9960d1e12e5b	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-gcp-secureboot	85de53883cc8f00e6a4c72d6895f9960d1e12e5b	link	false	`/test e2e-gcp-secureboot`
ci/prow/e2e-gcp-ovn-shared-vpc	85de53883cc8f00e6a4c72d6895f9960d1e12e5b	link	false	`/test e2e-gcp-ovn-shared-vpc`
ci/prow/e2e-azurestack	`fa32bf0`	link	false	`/test e2e-azurestack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-08-24T04:05:28Z

@rna-afk: Jira Issue OCPBUGS-17073: All pull requests linked via external trackers have merged:

openshift/installer#7412

Jira Issue OCPBUGS-17073 has been moved to the MODIFIED state.

Details

In response to this:

This reverts commit 87fbf26, reversing changes made to 26a0d5c.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OCPBUGS-17073: Revert "Merge pull request openshift#7205 from rna-afk/azure_managed_by_tag"

Revert "Merge pull request openshift#7205 from rna-afk/azure_managed_…

f828b08

…by_tag" This reverts commit 87fbf26, reversing changes made to 26a0d5c.

r4f4 reviewed Aug 9, 2023

View reviewed changes

openshift-ci bot assigned r4f4 Aug 9, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023

openshift-ci bot requested review from jhixson74 and mtulio August 9, 2023 16:38

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023

r4f4 reviewed Aug 10, 2023

View reviewed changes

terraform/providers/azurerm/go.mod Outdated Show resolved Hide resolved

r4f4 reviewed Aug 10, 2023

View reviewed changes

rna-afk force-pushed the revert_azure_managed_by branch from 85de538 to a34b535 Compare August 10, 2023 14:32

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023

patrickdillon changed the title ~~Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag"~~ OCPBUGS-17073: Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag" Aug 15, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023

openshift-ci bot assigned patrickdillon Aug 15, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023

openshift-ci bot requested a review from MayXuQQ August 15, 2023 21:22

MayXuQQ approved these changes Aug 16, 2023

View reviewed changes

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 23, 2023

terraform: set azurerm version to v3.43.0

fa32bf0

Setting to v3.43.0 to support confidential VMs.

rna-afk force-pushed the revert_azure_managed_by branch from d957492 to fa32bf0 Compare August 23, 2023 22:02

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 23, 2023

openshift-merge-robot merged commit d7f39ed into openshift:master Aug 24, 2023

patrickdillon pushed a commit to patrickdillon/installer that referenced this pull request Oct 24, 2023

Merge pull request openshift#7412 from rna-afk/revert_azure_managed_by

e930015

OCPBUGS-17073: Revert "Merge pull request openshift#7205 from rna-afk/azure_managed_by_tag"

Conversation

rna-afk commented Aug 9, 2023

Uh oh!

r4f4 left a comment

Choose a reason for hiding this comment

Uh oh!

r4f4 commented Aug 9, 2023

Uh oh!

Uh oh!

r4f4 left a comment

Choose a reason for hiding this comment

Uh oh!

r4f4 commented Aug 10, 2023

Uh oh!

rna-afk commented Aug 14, 2023

Uh oh!

patrickdillon commented Aug 14, 2023

Uh oh!

patrickdillon commented Aug 15, 2023

Uh oh!

patrickdillon commented Aug 15, 2023

Uh oh!

openshift-ci-robot commented Aug 15, 2023

Uh oh!

openshift-ci-robot commented Aug 15, 2023

Uh oh!

rna-afk commented Aug 15, 2023

Uh oh!

openshift-ci-robot commented Aug 15, 2023

Uh oh!

MayXuQQ commented Aug 16, 2023

Uh oh!

openshift-ci bot commented Aug 16, 2023

Uh oh!

rna-afk commented Aug 22, 2023

Uh oh!

openshift-ci-robot commented Aug 22, 2023

Uh oh!

openshift-ci-robot commented Aug 22, 2023

Uh oh!

openshift-ci-robot commented Aug 23, 2023

Uh oh!

r4f4 commented Aug 23, 2023

Uh oh!

openshift-ci-robot commented Aug 23, 2023

Uh oh!

r4f4 commented Aug 23, 2023

Uh oh!

rna-afk commented Aug 23, 2023

Uh oh!

r4f4 commented Aug 23, 2023

Uh oh!

openshift-ci-robot commented Aug 24, 2023

Uh oh!

openshift-ci bot commented Aug 24, 2023

Uh oh!

openshift-ci-robot commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants