Skip to content

OCPBUGS-26434: Redact platform passwords in agent-gather output#7873

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
bfournie:agent-platform-pwd-redact
Jan 16, 2024
Merged

OCPBUGS-26434: Redact platform passwords in agent-gather output#7873
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
bfournie:agent-platform-pwd-redact

Conversation

@bfournie
Copy link
Contributor

@bfournie bfournie commented Jan 8, 2024

Redact the platform passwords stored in agent-cluster-install when included in the agent-gather output.

Redact the platform passwords stored in agent-cluster-install when
included in the agent-gather output.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-26434, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Redact the platform passwords stored in agent-cluster-install when included in the agent-gather output.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Contributor Author

bfournie commented Jan 8, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-26434, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from andfasano, mhanss and zaneb January 8, 2024 13:48
@bfournie
Copy link
Contributor Author

bfournie commented Jan 8, 2024

/retest

@andfasano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@zaneb
Copy link
Member

zaneb commented Jan 15, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d208122 into openshift:master Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: Jira Issue OCPBUGS-26434: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26434 has been moved to the MODIFIED state.

Details

In response to this:

Redact the platform passwords stored in agent-cluster-install when included in the agent-gather output.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie bfournie deleted the agent-platform-pwd-redact branch January 16, 2024 01:17
@bfournie
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@bfournie: new pull request created: #7910

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-terraform-providers-container-v4.16.0-202401160407.p0.gd208122.assembly.stream for distgit ose-installer-terraform-providers.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants